Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: retention period update buckets #25989

Open
wants to merge 5 commits into
base: main-2.x
Choose a base branch
from
Open

fix: retention period update buckets #25989

wants to merge 5 commits into from
+83 −0

Conversation

NguyenHoangSon96
Copy link

@NguyenHoangSon96 NguyenHoangSon96 commented Feb 11, 2025 •
edited by bednar
Loading

Closes influxdata/ui#1607

Fix the bug when updating the retention period of buckets:

  • Before fix: set a retention period, eg. 1 hour, then change to never -> the retention period is still 1 hour
  • After fix: set a retention period, eg. 1 hour, then change to never -> the retention period changes to never
  • Test case added
  • Issue Link
Screen.Recording.2025-02-12.at.15.30.26.mov
  • I've read the contributing section of the project README.
  • Signed CLA (if not already signed).

@NguyenHoangSon96 NguyenHoangSon96 self-assigned this Feb 11, 2025
@NguyenHoangSon96 NguyenHoangSon96 marked this pull request as draft February 11, 2025 07:05
@NguyenHoangSon96 NguyenHoangSon96 marked this pull request as ready for review February 12, 2025 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bednar bednar Awaiting requested review from bednar

At least 1 approving review is required to merge this pull request.

Assignees

@NguyenHoangSon96 NguyenHoangSon96

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@NguyenHoangSon96