fix: handle default value for pb2 enums without a 0 value #136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flattoride
commented
Sep 12, 2024
flattoride
commented
- Fixed the issue where pb2 enums might not have a 0 value.
- Ensured that when a 0 value exists, pb2 defaults to the first enum value.
- Updated pbjson-build to handle enum value conversion using prost field methods instead of try_from.
- Resolved the serde::ser::Error::custom(format!("Invalid variant {{}}", {}))) error.
- Fixed the issue where pb2 enums might not have a 0 value.
- Ensured that when a 0 value exists, pb2 defaults to the first enum value.
- Updated pbjson-build to handle enum value conversion using prost field methods instead of try_from.
- Resolved the serde::ser::Error::custom(format!(\"Invalid variant {{}}\", {}))) error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.