Use serde_core where possible #148
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Seems like reproducing the auto-generated code requires something like |
Contributor
Can you elaborate why this is required? I'm failing to see the reason for that 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the newly released
serde_coreseems to have significant benefit for compile times,pbjsonis the main user left in Datafusion.This is a breaking change, as it generates different code (
serde_core::instead ofserde::), and also significantly moves up the requiredserde/serde_coreversions.There is one
#[derive(Deserialize)]which I couldn't figure out yet, but I figured its worth opening this PR for early feedback.