Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(secrets): Abstract secret implementation #13953

Merged
merged 4 commits into from
Sep 25, 2023

Conversation

srebhan
Copy link
Member

@srebhan srebhan commented Sep 20, 2023

This PR prepares the code to be able to solve #13807, #13806 and #13804 in a follow-up PR. It abstracts the secret handling from a concrete implementation backend holding the secret, memguard currently. In the course of doing so, we also get rid of copying the buffer around.

@telegraf-tiger telegraf-tiger bot added the chore label Sep 20, 2023
@srebhan srebhan force-pushed the secrets_alternatives branch from 9121ac4 to ecb250b Compare September 20, 2023 13:38
@srebhan srebhan force-pushed the secrets_alternatives branch from 8e41231 to 6801b8b Compare September 20, 2023 14:17
@srebhan srebhan added ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. plugin/secretstores labels Sep 20, 2023
config/secret.go Outdated Show resolved Hide resolved
@srebhan srebhan requested a review from powersj September 25, 2023 14:27
Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, looking forward to the next set of PRs for the secret store.

@powersj powersj merged commit e2c4e10 into influxdata:master Sep 25, 2023
@github-actions github-actions bot added this to the v1.28.2 milestone Sep 25, 2023
powersj pushed a commit that referenced this pull request Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore plugin/secretstores ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants