-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(secrets): Abstract secret implementation #13953
Conversation
9121ac4
to
ecb250b
Compare
8e41231
to
6801b8b
Compare
Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip. 👍 This pull request doesn't change the Telegraf binary size 📦 Click here to get additional PR build artifactsArtifact URLs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, looking forward to the next set of PRs for the secret store.
(cherry picked from commit e2c4e10)
This PR prepares the code to be able to solve #13807, #13806 and #13804 in a follow-up PR. It abstracts the secret handling from a concrete implementation backend holding the secret, memguard currently. In the course of doing so, we also get rid of copying the buffer around.