Chain Runtime implementation #364

romac · 2020-11-05T16:36:26Z

Closes: #330
Depends on: #401

Description

Critical Files

relayer/src/chain.rs
relayer/src/chain/cosmos.rs
relayer/src/chain/handle.rs
relayer/src/chain/handle/prod.rs
relayer/src/chain/runtime.rs

For contributor use:

Updated the Unreleased section of CHANGELOG.md with the issue.
If applicable: Unit tests written, added test to CI.
Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
Updated relevant documentation (docs/) and code comments.
Re-reviewed Files changed in the Github PR explorer.

…nHandle.

… data types

…unterpart

adizere

Still reviewing..

adizere · 2020-11-19T12:48:06Z

relayer/src/light_client/tendermint.rs

+    let _id = config.id.clone();
+


Suggested change

let _id = config.id.clone();

relayer/src/chain/runtime.rs

relayer/src/chain/cosmos.rs

relayer/src/chain/handle/prod.rs

romac · 2020-11-20T17:30:56Z

This is currently blocked because tonic (the gRPC implementation we use) is currently still using hyper 0.13 which in turn depends on Tokio 0.2. This means that we cannot issue gRPC queries from within a Tokio 0.3 runtime.

I will take a stab at getting tonic to use the dev 0.14 version of hyper next week.

romac · 2020-11-23T12:22:09Z

Unblocked this by depending on:

tendermint-rs branch romac/prost-dev with hyper and prost master for Tokio 0.3 compat: https://github.com/informalsystems/tendermint-rs/tree/romac/prost-dev
tonic fork with hyper 0.14-dev for Tokio 0.3 compat: https://github.com/romac/tonic/tree/romac/hyper-0.14-dev
bytes 0.6, as required by hyper 0.14-dev
prost master for bytes 0.6 support

This is all a bit of mess at the moment, and it's not clear when any of those libs will get a new release. We are perhaps going to have to push/help on that front directly.

ancazamfir · 2020-11-23T17:09:44Z

I opened #410 to collect followup from this PR.
Tested client create, update, connection and channel handshakes.
I think we are good to merge.

ancazamfir

Looks good! Thanks Romain!!!

* Attemptin integration at the level of Chain trait * Removed rpc client from trait Chain * Removed ChainConfig from trait Chain * Minor fixes as follow-up from #364 * Impl generic runtime instantiation. * Migrated CLIs to use generic runtime spawn. * Added mock light client. First test (incomplete impl). * Almost ready to send_tx (mock has to be mutable). * Added chain executor. * Mutable chain in send_tx, simplified spawn.After review w/ Anca & Romain * impl CosmosSDKChain cleanup * Adapted mock context, ICS18 & 26 to correct abstractions. * Cleaned up Msg trait, added const TYPE_URL. * Basic light client impl to complete create client test. * Removed clippy allow exception * Updated changelog * Revert "Updated changelog" This reverts commit 43bd008. In anticipation of merging master into this dev branch.. * Redid the changelog * After Anca's comments

…es (#448) * Starting refactor for Connection & Channel relayer objects * Make chain handle object-safe via dyn_clone. * Went back to clone() method [h/t Romain for suggesting clone_trait_object!] * Refactoring Connection and ForeignClient * Added tests for client update * Added height check in ForeignClient update tests * Removed useless test/code * Added changelog entry * Consolidating names (cf. review of #364). * Added more semantic deps

* Started v0 impl: re-arranging handlers + initialization. * Clean up chain handle, prepare for generic client creation. * Trying different boundaries of abstraction b/t ForeignClient and ChainHandle. * Version one: introduced assemble_ methods to construct chain-specific data types * Removed signer from foreign client config * FMT quick fix * Client ID parsing * Use ibc::ics24_host::identifier::ChainId instead of its tendermint counterpart * More error handling and split into modules * Move prod handle in its own module * Cleanup * Overhaul subscriptions handling * Add struct to represent a batch of events * Move SplitResults trait into its own module * WIP: More handle inputs * Better errors * Implement `query` in chain runtime * Assemble client state and consensus state in runtime * Launch light clients * Light Block * Remove unused file * Rename two handle inputs * Rename Chain::ics_query to Chain::query * Store the domain MerkleProof in QueryResponse instead of the raw MerkleProof * Implement all chain methods in runtime + handle * Chain methods should return their Self types * Use light client to build consensus state * Use light client to retrieve and build header * Comment out currently unused code * Formatting * Make keybase field of CosmosSDKChain private * Fix tests * Properly spawn runtime * Revert 2afa90f * Allow a ChainId to not include version number, default to 0 * Upgrade Tokio to version 0.3 * WIP: event monitor * Syncify EventMonitor * Cleanup * Use shared Tokio runtime to `block_on` instead of spawning new one * Cleanup * Nest event_handler and event_monitor modules under event module * WIP: event bus * Cleanup * Fix build issue * Add tests for event bus * Cleanup * Update listen command * Point to tendermint-rs branch with Tokio 0.3 * Remove unused downcast_* methods * Re-enable some lints * Cleanup * Use tendermint-rs master * Depend on tendermint-rs prost-dev branch * Formatting * Deserialize client queries in Any types, temp fix for validator set Co-authored-by: Adi Seredinschi <[email protected]> Co-authored-by: Anca Zamfir <[email protected]>

* Attemptin integration at the level of Chain trait * Removed rpc client from trait Chain * Removed ChainConfig from trait Chain * Minor fixes as follow-up from informalsystems#364 * Impl generic runtime instantiation. * Migrated CLIs to use generic runtime spawn. * Added mock light client. First test (incomplete impl). * Almost ready to send_tx (mock has to be mutable). * Added chain executor. * Mutable chain in send_tx, simplified spawn.After review w/ Anca & Romain * impl CosmosSDKChain cleanup * Adapted mock context, ICS18 & 26 to correct abstractions. * Cleaned up Msg trait, added const TYPE_URL. * Basic light client impl to complete create client test. * Removed clippy allow exception * Updated changelog * Revert "Updated changelog" This reverts commit 43bd008. In anticipation of merging master into this dev branch.. * Redid the changelog * After Anca's comments

…es (informalsystems#448) * Starting refactor for Connection & Channel relayer objects * Make chain handle object-safe via dyn_clone. * Went back to clone() method [h/t Romain for suggesting clone_trait_object!] * Refactoring Connection and ForeignClient * Added tests for client update * Added height check in ForeignClient update tests * Removed useless test/code * Added changelog entry * Consolidating names (cf. review of informalsystems#364). * Added more semantic deps

adizere and others added 16 commits October 29, 2020 12:12

Started v0 impl: re-arranging handlers + initialization.

1f4b0d4

Clean up chain handle, prepare for generic client creation.

8ef0d63

Trying different boundaries of abstraction b/t ForeignClient and Chai…

4291e74

…nHandle.

Version one: introduced assemble_ methods to construct chain-specific…

dcef8a7

… data types

Removed signer from foreign client config

d00cb98

Merge branch 'master' into adi/346_V0_implementation

0eb1611

FMT quick fix

23e750a

Client ID parsing

3c82990

Use ibc::ics24_host::identifier::ChainId instead of its tendermint co…

4c24b67

…unterpart

More error handling and split into modules

52d9fba

Move prod handle in its own module

394a824

Cleanup

9854506

Overhaul subscriptions handling

9f1a42e

Add struct to represent a batch of events

b1baf7e

Move SplitResults trait into its own module

a7112ba

WIP: More handle inputs

2809cbd

romac requested a review from ancazamfir as a code owner November 5, 2020 16:36

romac marked this pull request as draft November 5, 2020 16:36

romac added 3 commits November 10, 2020 20:57

Better errors

89e5320

Implement query in chain runtime

cc71d0c

Assemble client state and consensus state in runtime

189bde0

romac force-pushed the romac/chain-runtime branch from 5366130 to 62b9498 Compare November 11, 2020 11:40

romac and others added 4 commits November 11, 2020 12:42

Launch light clients

9dd2a8a

Light Block

cab6f72

Merge branch 'master' into adi/346_V0_implementation

166352d

Merge branch 'adi/346_V0_implementation' into romac/chain-runtime

17ba302

romac force-pushed the romac/chain-runtime branch from 62b9498 to 17ba302 Compare November 11, 2020 21:09

Base automatically changed from adi/346_V0_implementation to master November 12, 2020 10:14

romac added 2 commits November 12, 2020 12:28

Merge branch 'master' into romac/chain-runtime

ef82617

Remove unused file

357d7c2

romac marked this pull request as ready for review November 19, 2020 14:22

adizere reviewed Nov 19, 2020

View reviewed changes

Merge branch 'master' into romac/chain-runtime

052d4f7

adizere reviewed Nov 19, 2020

View reviewed changes

relayer/src/chain/handle/prod.rs Show resolved Hide resolved

adizere mentioned this pull request Nov 20, 2020

Upgrade Tokio to version 0.3.0 informalsystems/tendermint-rs#681

Merged

9 tasks

romac added 2 commits November 20, 2020 15:30

Merge branch 'master' into romac/chain-runtime

52eb208

Use tendermint-rs master

de190ab

romac added the A: blocked Admin: blocked by another (internal/external) issue or PR label Nov 20, 2020

Depend on tendermint-rs prost-dev branch

835e002

romac removed the A: blocked Admin: blocked by another (internal/external) issue or PR label Nov 23, 2020

Merge branch 'master' into romac/chain-runtime

dcae53d

romac and others added 2 commits November 23, 2020 13:22

Formatting

96d66a4

Deserialize client queries in Any types, temp fix for validator set

1e6a02a

ancazamfir approved these changes Nov 23, 2020

View reviewed changes

romac merged commit 5f71413 into master Nov 23, 2020

romac deleted the romac/chain-runtime branch November 23, 2020 17:20

romac mentioned this pull request Nov 24, 2020

Downgrade back to Tokio 0.2 #415

Closed

5 tasks

adizere mentioned this pull request Nov 26, 2020

Rename Raw types into Proto types #423

Closed

5 tasks

adizere added a commit that referenced this pull request Nov 27, 2020

Minor fixes as follow-up from #364

ba30310

adizere added a commit that referenced this pull request Dec 11, 2020

Consolidating names (cf. review of #364).

1e9335b

This was referenced Dec 23, 2020

Implement the Relayer v0 concurrency architecture #327

Closed

Implement query_header_at_height() #336

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Chain Runtime implementation #364

Chain Runtime implementation #364

romac commented Nov 5, 2020 •

edited

Loading

adizere left a comment

adizere Nov 19, 2020

romac commented Nov 20, 2020

romac commented Nov 23, 2020

ancazamfir commented Nov 23, 2020 •

edited

Loading

ancazamfir left a comment

Chain Runtime implementation #364

Chain Runtime implementation #364

Conversation

romac commented Nov 5, 2020 • edited Loading

Description

Critical Files

adizere left a comment

Choose a reason for hiding this comment

adizere Nov 19, 2020

Choose a reason for hiding this comment

romac commented Nov 20, 2020

romac commented Nov 23, 2020

ancazamfir commented Nov 23, 2020 • edited Loading

ancazamfir left a comment

Choose a reason for hiding this comment

romac commented Nov 5, 2020 •

edited

Loading

ancazamfir commented Nov 23, 2020 •

edited

Loading