Skip to content

Commit

Permalink
fix: remove non-existing ibc-client-cw link in workspace (#1358)
Browse files Browse the repository at this point in the history
* fix: remove non-existing ibc-client-cw link in workspace

* chore: add changelog

* fix: make linters happy
  • Loading branch information
Farhad-Shabani authored Oct 16, 2024
1 parent ac53b28 commit e50ae6c
Show file tree
Hide file tree
Showing 5 changed files with 10 additions and 12 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- [ibc] Remove non-existing `ibc-client-cw` link in the `Cargo.toml` workspace.
([#1357](https://github.com/cosmos/ibc-rs/issues/1357)).
3 changes: 0 additions & 3 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,5 @@ mc.log
# caused by a dependency updated to a faulty version.
/Cargo.lock

# Ignore CosmWasm artifacts
cw-contracts/

# Ignore dotenv
.env
1 change: 0 additions & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,6 @@ ibc-core-handler = { version = "0.55.0", path = "./ibc-core/ics25-handler", d
ibc-core-router = { version = "0.55.0", path = "./ibc-core/ics26-routing", default-features = false }
ibc-query = { version = "0.55.0", path = "./ibc-query", default-features = false }

ibc-client-cw = { version = "0.55.0", path = "./ibc-clients/cw-context", default-features = false }
ibc-client-tendermint = { version = "0.55.0", path = "./ibc-clients/ics07-tendermint", default-features = false }

ibc-app-transfer = { version = "0.55.0", path = "./ibc-apps/ics20-transfer", default-features = false }
Expand Down
6 changes: 3 additions & 3 deletions docs/architecture/adr-001-handler-implementation.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ and eventually picked up by the IBC relayer.

An event has an arbitrary structure, depending on the handler that produces it.
Here is the [list of all IBC-related events][events], as seen by the relayer.
Note that the consumer of these events in production would not be the relayer directly
Note that the consumer of these events in production would not be the relayer directly
(instead the consumer is the node/SDK where the IBC module executes),
but nevertheless handlers will reuse these event definitions.

Expand All @@ -41,7 +41,7 @@ pub enum IBCEvent {
OpenInitConnection(ConnectionEvents::OpenInit),
OpenTryConnection(ConnectionEvents::OpenTry),
// ...
}
}
```

### Logging
Expand Down Expand Up @@ -445,7 +445,7 @@ which are agnostic to the actual type of client being used.

We could alternatively model all chain-specific datatypes as boxed trait objects (`Box<dyn Trait>`),
but this approach runs into a lot of limitations of trait objects, such as the inability to easily
require such trait objects to be Clonable, or Serializable, or to define an equality relation on them.
require such trait objects to be Cloneable, or Serializable, or to define an equality relation on them.
Some support for such functionality can be found in third-party libraries, but the overall experience
for the developer is too subpar.

Expand Down
10 changes: 5 additions & 5 deletions docs/architecture/adr-004-light-client-crates-extraction.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ in [ADR003 - Dealing with chain-specific datatypes](https://github.com/informals
->
> We could alternatively model all chain-specific datatypes as boxed trait objects (`Box<dyn Trait>`), but this approach
> runs into a lot of limitations of trait objects, such as the inability to easily require such trait objects to be
> Clonable, or Serializable, or to define an equality relation on them. Some support for such functionality can be found
> Cloneable, or Serializable, or to define an equality relation on them. Some support for such functionality can be found
> in third-party libraries, but the overall experience for the developer is too subpar.
>
> We thus settle on a different strategy: lifting chain-specific data into an enum over all possible chain types.
Expand Down Expand Up @@ -183,7 +183,7 @@ available).

#### Light client traits cannot have constructors

This restriction comes from the fact that trait methods of object safe traits cannot return `Self`.
This restriction comes from the fact that trait methods of object safe traits cannot return `Self`.
However, we would need a constructor to be able to create a `ClientState` and `ConsensusState` in the `create_client`
handler. This can be done using a `where Self: Sized` clause on the trait method.

Expand Down Expand Up @@ -348,7 +348,7 @@ define_error! {
#[derive(Debug, PartialEq, Eq)]
Error {
/* ... */

Tendermint
[ Ics07Error ]
| _ | { "tendermint error" },
Expand All @@ -371,11 +371,11 @@ define_error! {
#[derive(Debug, PartialEq, Eq)]
Error {
/* ... */

ClientSpecific
{ description: String }
| e | { format_args!("client specific error: {0}", e.description) },

/* ... */
}
}
Expand Down

0 comments on commit e50ae6c

Please sign in to comment.