Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v0.49.0 #1021

Merged
merged 13 commits into from
Jan 3, 2024
Merged

Release v0.49.0 #1021

merged 13 commits into from
Jan 3, 2024

Conversation

seanchen1991
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Jan 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d96cc66) 71.21% compared to head (9239ca7) 71.21%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1021   +/-   ##
=======================================
  Coverage   71.21%   71.21%           
=======================================
  Files         178      178           
  Lines       18198    18198           
=======================================
  Hits        12959    12959           
  Misses       5239     5239           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Farhad-Shabani Farhad-Shabani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!
Just per our discussion, let's move away from the release.sh and update the CI's release workflow to use the cargo release ... instead.

@seanchen1991 seanchen1991 marked this pull request as ready for review January 2, 2024 17:30
@Farhad-Shabani Farhad-Shabani added this to the v0.49.0 milestone Jan 3, 2024
@Farhad-Shabani
Copy link
Member

I've gone ahead and revised the release job, and it should be all set now.
By the way, before we move on, could @rnbguy please take a look at it? Thanks!

Copy link
Member

@rnbguy rnbguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments. Otherwise, LGTM 🚀

.changelog/v0.49.0/summary.md Outdated Show resolved Hide resolved
.changelog/v0.49.0/summary.md Outdated Show resolved Hide resolved
.changelog/v0.49.0/summary.md Outdated Show resolved Hide resolved
.github/workflows/release.yaml Outdated Show resolved Hide resolved
.github/workflows/release.yaml Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@seanchen1991 seanchen1991 merged commit e340d1e into main Jan 3, 2024
17 checks passed
@seanchen1991 seanchen1991 deleted the release/v0.49.0 branch January 3, 2024 15:09
Farhad-Shabani added a commit that referenced this pull request Sep 9, 2024
* Add v0.49 changelog

* Update cargo.toml dependency versions

* Use infallible conversion method where appropriate

* Bump ibc-derive version

* Update ibc-derive deps version

* Update RELEASES.md doc

* Update release workflow to use `cargo release`

* Remove release.sh script in favor of `cargo release` command

* CI: add job for release-check

* fix: revise if conditions

* fix: release.yaml if condition

* rewrite release.yaml + apply linter on CHANGELOG.md

* Incorporate some PR feedback

---------

Co-authored-by: Farhad Shabani <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants