-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v0.49.0 #1021
Release v0.49.0 #1021
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1021 +/- ##
=======================================
Coverage 71.21% 71.21%
=======================================
Files 178 178
Lines 18198 18198
=======================================
Hits 12959 12959
Misses 5239 5239 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you!
Just per our discussion, let's move away from the release.sh
and update the CI's release workflow to use the cargo release ...
instead.
I've gone ahead and revised the release job, and it should be all set now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some comments. Otherwise, LGTM 🚀
* Add v0.49 changelog * Update cargo.toml dependency versions * Use infallible conversion method where appropriate * Bump ibc-derive version * Update ibc-derive deps version * Update RELEASES.md doc * Update release workflow to use `cargo release` * Remove release.sh script in favor of `cargo release` command * CI: add job for release-check * fix: revise if conditions * fix: release.yaml if condition * rewrite release.yaml + apply linter on CHANGELOG.md * Incorporate some PR feedback --------- Co-authored-by: Farhad Shabani <[email protected]>
No description provided.