imp: ehnance ICS-07 CosmWasm tests using Timestamp::now() + add test_cw_client_expiry
#1181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1181 +/- ##
==========================================
- Coverage 64.39% 64.37% -0.03%
==========================================
Files 230 230
Lines 22053 22053
==========================================
- Hits 14201 14196 -5
- Misses 7852 7857 +5 ☔ View full report in Codecov by Sentry. |
rnbguy
reviewed
Apr 24, 2024
| let header = tendermint_testgen::Header::new(&self.validators) | ||
| .chain_id(self.chain_id.as_str()) | ||
| .height(header_height.revision_height()) | ||
| .time(future_time) | ||
| .time(Time::now()) |
There was a problem hiding this comment.
we can take it as argument to the method.
There was a problem hiding this comment.
let's refactor for parametrized testing in separate PRs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant to: #1176
Description
I meant to write a test to cover the scenario that #1176 aimed to address. However, I didn't get a chance to complete this task before my leave. Nonetheless, I managed to make some improvements, such as utilizing
Timestamp::now(), which enables a more accurate simulation of real-world cases like client expiry. I also addedtest_cw_client_expiry.@rnbguy Please feel free to apply your review directly to this PR and proceed with merging it.
PR author checklist:
Reviewer checklist:
Files changedin the GitHub PR explorer.