imp(ics-07): simplify ClientType impl in cw contract
#1202
Merged
+25
−68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1202 +/- ##
==========================================
- Coverage 64.45% 64.36% -0.09%
==========================================
Files 229 228 -1
Lines 22055 22001 -54
==========================================
- Hits 14215 14162 -53
+ Misses 7840 7839 -1 ☔ View full report in Codecov by Sentry. |
rnbguy
force-pushed
the
rano/ics07/simplify-cw-client
branch
from
423f832 to
f52197c
Compare
rnbguy
force-pushed
the
rano/ics07/simplify-cw-client
branch
from
f535fa1 to
4cdb0e9
Compare
rnbguy
commented
Apr 28, 2024
Signed-off-by: Rano | Ranadeep <[email protected]>
…07/simplify-cw-client
seanchen1991
approved these changes
May 3, 2024
Farhad-Shabani
pushed a commit
that referenced
this pull request
Sep 9, 2024
* impl TryFrom * simplify Tendermint ClientType impl * add comment * rm Clone bound * Implement From<ConsensusState> * Remove unneeded dependency * Format cargo.toml file * nit * update gh workflow titles --------- Signed-off-by: Rano | Ranadeep <[email protected]> Co-authored-by: Sean Chen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1201
Description
PR author checklist:
unclog.docs/).Reviewer checklist:
Files changedin the GitHub PR explorer.