Skip to content

fix(wal): add reply for Msg::StartedHeight #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+4 −1
Open

fix(wal): add reply for Msg::StartedHeight #17

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
db996b6
Added missing reply sending
kirdatatjana Sep 18, 2025
18de0d5
Merge branch 'main' into tatjana/fix/wal_silent_failiure
kirdatatjana Sep 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion code/crates/engine/src/wal.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,10 @@ where
match msg {
Msg::StartedHeight(height, reply_to) => {
if state.height == height {
debug!(%height, "WAL already at height, ignoring");
debug!(%height, "WAL already at height, returning empty entries");
reply_to
.send(Ok(None))
.map_err(|e| eyre!("Failed to send reply: {e}"))?;
return Ok(());
}

Expand Down