Skip to content

Conversation

kirdatatjana
Copy link
Collaborator

Closes: #8

This PR introduces changes that resolve issues present in the anca/starknet_interop branch at commit cc5994d.

The branch anca/starknet_interop contains the Malachite code changes required for the starknet-interop repository. These modifications enable Malachite nodes to connect and participate in consensus with Starknet Sequencer nodes.

The last stable commit was:
cc5994d11c82a7b0955b01e87efd58fcbc7361f8, Update Malachite config template

Issues Identified in the Commit

if !state.peers.is_empty() {
    tokio::time::sleep(Duration::from_millis(200)).await;
    
    consensus.cast(ConsensusMsg::StartHeight(
	      start_height,
	      state.host.validator_set.clone(),
    ))?;
}
  • Malachite proposals failed validation due to an incorrect proposal_commitment_hash (code ref).
  • The configured timeout durations were too short, resulting in multiple rounds per height.

Note

This branch is not intended for merging into the main branch.


PR author checklist

For all contributors

For external contributors

ancazamfir and others added 30 commits February 18, 2025 19:33
- Use `starknet_api`'s `ContractAddress` type for addresses
- Propose empty blocks
- Fix `BlockInfo` proposal part to match the sequencer's version
- Add validator address in genesis and private key file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix(interop): Consensus does not transition from Ready to Running phase
4 participants