forked from circlefin/malachite
-
Notifications
You must be signed in to change notification settings - Fork 0
fix: Starknet interoperability #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
kirdatatjana
wants to merge
58
commits into
main
Choose a base branch
from
tatjana/starknet_interop
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use `starknet_api`'s `ContractAddress` type for addresses - Propose empty blocks - Fix `BlockInfo` proposal part to match the sequencer's version - Add validator address in genesis and private key file
* feat(code/starknet): Derive address from public key * Allow sync to be enabled via config --------- Co-authored-by: Anca Zamfir <[email protected]>
…und: Proposer, Validator, or None (circlefin#1055)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #8
This PR introduces changes that resolve issues present in the
anca/starknet_interop
branch at commitcc5994d
.The branch
anca/starknet_interop
contains the Malachite code changes required for thestarknet-interop
repository. These modifications enable Malachite nodes to connect and participate in consensus with Starknet Sequencer nodes.The last stable commit was:
cc5994d11c82a7b0955b01e87efd58fcbc7361f8
, Update Malachite config templateIssues Identified in the Commit
Ready
toRunning
phase. This is primarily due to the validation implemented in code/crates/starknet/host/src/actor.rsproposal_commitment_hash
(code ref).Note
This branch is not intended for merging into the
main
branch.PR author checklist
For all contributors
For external contributors