This repository has been archived by the owner on Jun 24, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 5
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat: implement
verify_client_message method for DA (Celestia) part (…
…#117) * chore: implement verify_client_message * fix: use same validators set for all tests * fix: use valid next_validators_hash for MockDaSpec * chore: update basecoin rev
- Loading branch information
1 parent
63562e7
commit 05c8ebe
Showing
16 changed files
with
521 additions
and
172 deletions.
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,77 @@ | ||
| use ibc_client_tendermint::client_state::verify_misbehaviour_header; | ||
| use ibc_client_tendermint::context::TmVerifier; | ||
| use ibc_core::client::types::error::ClientError; | ||
| use ibc_core::host::types::identifiers::{ChainId, ClientId}; | ||
| use ibc_core::host::types::path::ClientConsensusStatePath; | ||
| use sov_celestia_client_types::client_message::SovTmMisbehaviour; | ||
| use tendermint_light_client_verifier::options::Options; | ||
|
|
||
| use crate::context::{ConsensusStateConverter, ValidationContext as SovValidationContext}; | ||
|
|
||
| /// Determines whether or not two conflicting headers at the same height would | ||
| /// have convinced the light client. | ||
| pub fn verify_misbehaviour<V>( | ||
| ctx: &V, | ||
| misbehaviour: &SovTmMisbehaviour, | ||
| client_id: &ClientId, | ||
| chain_id: &ChainId, | ||
| options: &Options, | ||
| verifier: &impl TmVerifier, | ||
| ) -> Result<(), ClientError> | ||
| where | ||
| V: SovValidationContext, | ||
| V::ConsensusStateRef: ConsensusStateConverter, | ||
| { | ||
| misbehaviour.validate_basic()?; | ||
|
|
||
| let header_1 = misbehaviour.header1(); | ||
| let trusted_consensus_state_1 = { | ||
| let consensus_state_path = ClientConsensusStatePath::new( | ||
| client_id.clone(), | ||
| header_1.trusted_height().revision_number(), | ||
| header_1.trusted_height().revision_height(), | ||
| ); | ||
| let consensus_state = ctx.consensus_state(&consensus_state_path)?; | ||
|
|
||
| consensus_state.try_into()? | ||
| }; | ||
|
|
||
| let header_2 = misbehaviour.header2(); | ||
| let trusted_consensus_state_2 = { | ||
| let consensus_state_path = ClientConsensusStatePath::new( | ||
| client_id.clone(), | ||
| header_2.trusted_height().revision_number(), | ||
| header_2.trusted_height().revision_height(), | ||
| ); | ||
| let consensus_state = ctx.consensus_state(&consensus_state_path)?; | ||
|
|
||
| consensus_state.try_into()? | ||
| }; | ||
|
|
||
| let current_timestamp = ctx.host_timestamp()?; | ||
|
|
||
| verify_misbehaviour_header( | ||
| &header_1.da_header, | ||
| chain_id, | ||
| options, | ||
| trusted_consensus_state_1.timestamp(), | ||
| trusted_consensus_state_1.da_params.next_validators_hash, | ||
| current_timestamp, | ||
| verifier, | ||
| )?; | ||
|
|
||
| verify_misbehaviour_header( | ||
| &header_2.da_header, | ||
| chain_id, | ||
| options, | ||
| trusted_consensus_state_2.timestamp(), | ||
| trusted_consensus_state_2.da_params.next_validators_hash, | ||
| current_timestamp, | ||
| verifier, | ||
| )?; | ||
|
|
||
| // TODO: Determine what sort of checks we need to carry out for detecting | ||
| // `AggregatedProofData` misbehaviour. | ||
|
|
||
| Ok(()) | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,125 @@ | ||
| use ibc_client_tendermint::context::TmVerifier; | ||
| use ibc_client_tendermint::types::Header as TmHeader; | ||
| use ibc_core::client::types::error::ClientError; | ||
| use ibc_core::host::types::identifiers::{ChainId, ClientId}; | ||
| use ibc_core::host::types::path::ClientConsensusStatePath; | ||
| use sov_celestia_client_types::client_message::SovTmHeader; | ||
| use sov_celestia_client_types::error::IntoResult; | ||
| use tendermint_light_client_verifier::options::Options; | ||
| use tendermint_light_client_verifier::types::{TrustedBlockState, UntrustedBlockState}; | ||
| use tendermint_light_client_verifier::Verifier; | ||
|
|
||
| use crate::context::{ConsensusStateConverter, ValidationContext as SovValidationContext}; | ||
|
|
||
| /// Verifies the IBC header type for the Sovereign SDK rollups, which consists | ||
| /// of the DA header and the aggregated proof date validation. | ||
| pub fn verify_header<V>( | ||
| ctx: &V, | ||
| header: &SovTmHeader, | ||
| client_id: &ClientId, | ||
| chain_id: &ChainId, | ||
| options: &Options, | ||
| verifier: &impl TmVerifier, | ||
| ) -> Result<(), ClientError> | ||
| where | ||
| V: SovValidationContext, | ||
| V::ConsensusStateRef: ConsensusStateConverter, | ||
| { | ||
| // Checks the sanity of the fields in the header. | ||
| header.validate_basic()?; | ||
|
|
||
| verify_da_header( | ||
| ctx, | ||
| &header.da_header, | ||
| client_id, | ||
| chain_id, | ||
| options, | ||
| verifier, | ||
| )?; | ||
|
|
||
| // TODO: Implement the verification of the `AggregatedProofData`. | ||
| // aggregated_proof_date.verify()?; | ||
|
|
||
| Ok(()) | ||
| } | ||
|
|
||
| /// Verifies the DA header type for the Sovereign SDK rollups against the | ||
| /// trusted state. | ||
| pub fn verify_da_header<V>( | ||
| ctx: &V, | ||
| da_header: &TmHeader, | ||
| client_id: &ClientId, | ||
| chain_id: &ChainId, | ||
| options: &Options, | ||
| verifier: &impl TmVerifier, | ||
| ) -> Result<(), ClientError> | ||
| where | ||
| V: SovValidationContext, | ||
| V::ConsensusStateRef: ConsensusStateConverter, | ||
| { | ||
| // The revision number of the `ChainId` tracked by the client state must | ||
| // match the `ChainId` in the DA header. | ||
| da_header | ||
| .verify_chain_id_version_matches_height(chain_id) | ||
| .map_err(|e| ClientError::Other { | ||
| description: format!("failed to verify chain id: {e}"), | ||
| })?; | ||
|
|
||
| let trusted_height = da_header.trusted_height; | ||
|
|
||
| let trusted_state = { | ||
| let trusted_client_cons_state_path = ClientConsensusStatePath::new( | ||
| client_id.clone(), | ||
| trusted_height.revision_number(), | ||
| trusted_height.revision_height(), | ||
| ); | ||
| let trusted_consensus_state = ctx | ||
| .consensus_state(&trusted_client_cons_state_path)? | ||
| .try_into()?; | ||
|
|
||
| da_header.check_trusted_next_validator_set( | ||
| &trusted_consensus_state.da_params.next_validators_hash, | ||
| )?; | ||
|
|
||
| TrustedBlockState { | ||
| chain_id: &chain_id | ||
| .to_string() | ||
| .try_into() | ||
| .map_err(|e| ClientError::Other { | ||
| description: format!("failed to parse chain id: {e}"), | ||
| })?, | ||
| header_time: trusted_consensus_state.timestamp(), | ||
| height: trusted_height.revision_height().try_into().map_err(|_| { | ||
| ClientError::Other { | ||
| description: "failed to convert revision height to u64".to_string(), | ||
| } | ||
| })?, | ||
| next_validators: &da_header.trusted_next_validator_set, | ||
| next_validators_hash: trusted_consensus_state.da_params.next_validators_hash, | ||
| } | ||
| }; | ||
|
|
||
| let untrusted_state = UntrustedBlockState { | ||
| signed_header: &da_header.signed_header, | ||
| validators: &da_header.validator_set, | ||
| // NB: This will skip the | ||
| // VerificationPredicates::next_validators_match check for the | ||
| // untrusted state. | ||
| next_validators: None, | ||
| }; | ||
|
|
||
| let now = ctx | ||
| .host_timestamp()? | ||
| .into_tm_time() | ||
| .ok_or_else(|| ClientError::ClientSpecific { | ||
| description: "host timestamp is not a valid TM timestamp".to_string(), | ||
| })?; | ||
|
|
||
| // main header verification, delegated to the tendermint-light-client crate. | ||
| verifier | ||
| .verifier() | ||
| .verify_update_header(untrusted_state, trusted_state, options, now) | ||
| .into_result()?; | ||
|
|
||
| Ok(()) | ||
| } |
Oops, something went wrong.