This repository has been archived by the owner on Jun 24, 2024. It is now read-only.
Use git URL for normal cargo build, and vendored file path for Nix build #155
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
cargo build
.Motivation
The use of git submodule turns out to not work well with Cargo. When one tries to run
cargo build
with git dependencies with git submodules, Cargo will almost always try to also fetch the git submodule, whether it is required in the Cargo dependency or not.Because of this, we need to use back git dependency for Sovereign SDK modules. On the other hand, in Nix we would patch the git dependencies, and replace them with path dependencies in order to work in Nix. This is because the Nix Rust build still does not support private repository, and we still need to use local vendored file path dependency inside the Nix build.