Skip to content
This repository has been archived by the owner on Jun 24, 2024. It is now read-only.

feat: emit helper packet events for indexing pending packets #64

Merged
merged 7 commits into from
Mar 6, 2024

Conversation

Farhad-Shabani
Copy link
Member

@Farhad-Shabani Farhad-Shabani commented Feb 8, 2024

Closes: #63

Description

  • To derive the string representation of the key bytes, I opted for base64 encoding due to its perceived safety, and a more human-readable output.
  • The add_event method for publishing IBC events has been superseded by the newly exposed emit_event method.

PR author checklist

  • Linked to GitHub issue.
  • Added tests.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

@Farhad-Shabani Farhad-Shabani marked this pull request as ready for review February 8, 2024 04:27
@Farhad-Shabani
Copy link
Member Author

Merging this PR so we can have the typed events along with auxiliaries in our next sov-rollup-starter update. In case the logic of constructing aux events should be improved, we will consolidate it later.

@Farhad-Shabani Farhad-Shabani merged commit f49563b into main Mar 6, 2024
10 checks passed
@Farhad-Shabani Farhad-Shabani deleted the farhad/emit-helper-events branch March 6, 2024 03:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Emit helper events by sov-ibc to allow indexing pending packets
1 participant