Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OP-1043 | Implement soft delete on user and usergroup #1439

Merged
merged 43 commits into from
Nov 14, 2024
Merged

OP-1043 | Implement soft delete on user and usergroup #1439

merged 43 commits into from
Nov 14, 2024

Conversation

SteveGT96
Copy link
Contributor

@SteveGT96 SteveGT96 commented Oct 25, 2024 •
edited by jira bot
Loading

See OP-1043

dbmalkovsky
dbmalkovsky requested changes Oct 28, 2024
View reviewed changes
Copy link
Collaborator

@dbmalkovsky dbmalkovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left specific and general comments.

mwithi
mwithi previously approved these changes Oct 29, 2024
View reviewed changes
Copy link
Member

@mwithi mwithi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please provide other PRs on API and GUI. Don't forget about DOC in a later step.

@SteveGT96
Copy link
Contributor Author

LGTM. Please provide other PRs on API and GUI. Don't forget about DOC in a later step.

Other PRs on GUI and API ? GUI and API are compatible with this PRs. If you try to delete use from GUI or API, it'll be soft deleted and you won't get it any more in future requests. For the doc, which doc are you talking about ? The doc module ? (I didn't work on it yet), or the API doc ?

@mwithi
Copy link
Member

mwithi commented Oct 29, 2024

LGTM. Please provide other PRs on API and GUI. Don't forget about DOC in a later step.

Other PRs on GUI and API ? GUI and API are compatible with this PRs. If you try to delete use from GUI or API, it'll be soft deleted and you won't get it any more in future requests. For the doc, which doc are you talking about ? The doc module ? (I didn't work on it yet), or the API doc ?

Left comments under the issue for discussion

@SteveGT96
Copy link
Contributor Author

LGTM. Please provide other PRs on API and GUI. Don't forget about DOC in a later step.

Other PRs on GUI and API ? GUI and API are compatible with this PRs. If you try to delete use from GUI or API, it'll be soft deleted and you won't get it any more in future requests. For the doc, which doc are you talking about ? The doc module ? (I didn't work on it yet), or the API doc ?

Left comments under the issue for discussion

OK, I'm gonna check them ASAP.

dbmalkovsky
dbmalkovsky previously requested changes Oct 29, 2024
View reviewed changes
Copy link
Collaborator

@dbmalkovsky dbmalkovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The conversation was only partially resolved.

mwithi
mwithi previously approved these changes Nov 11, 2024
View reviewed changes
Copy link
Member

@mwithi mwithi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks a lot!

mwithi
mwithi previously approved these changes Nov 13, 2024
View reviewed changes
Copy link
Member

@mwithi mwithi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks a lot!

dbmalkovsky
dbmalkovsky reviewed Nov 13, 2024
View reviewed changes
Copy link
Collaborator

@dbmalkovsky dbmalkovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments

mwithi
mwithi approved these changes Nov 14, 2024
View reviewed changes
Copy link
Member

@mwithi mwithi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks a lot!

@mwithi mwithi merged commit 5c891a4 into informatici:develop Nov 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbmalkovsky dbmalkovsky dbmalkovsky left review comments

@mwithi mwithi mwithi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SteveGT96 @mwithi @dbmalkovsky