OP-1363 | Fix NullPointerexception #2089
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbmalkovsky
reviewed
Nov 19, 2024
dbmalkovsky
reviewed
Nov 19, 2024
dbmalkovsky
reviewed
Nov 19, 2024
Co-authored-by: David B Malkovsky <[email protected]>
Co-authored-by: David B Malkovsky <[email protected]>
Co-authored-by: David B Malkovsky <[email protected]>
mwithi
reviewed
Nov 19, 2024
| @@ -1197,6 +1197,7 @@ angal.newbill.payment.btn.key | |||
| angal.newbill.paymentmadebeforebilldate.msg = Payment made before bill date. | |||
| angal.newbill.paymentreceipt.btn = Payment Receipt | |||
| angal.newbill.paymentreceipt.btn.key = N | |||
| angal.newbill.pleasefindpatientbeforeremotehim.msg = Please find the patient first before trying to remove him. | |||
There was a problem hiding this comment.
I think "him"/"her" is not very professional here, also I don't think the suggestion make sense (no one wants to find a record in order to suddenly remove it).
Why we don't make just the button doing nothing if patient is null?
Also, we can disable the button when no patient is selected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See OP-1363.