-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New properties for cross-species equivalents #107
Comments
What speaks against using skos:exactMatch etc. for that, if I may ask? |
I object to using
With any of those properties, the fact that we would be talking about a cross-species mapping could only be deduced by looking at which ontologies the mapped terms belong to, observe that they are about different species (or that one is species-neutral while the other is species-specific), and therefore conclude “this must be a cross-species mapping”. Can’t we do better? Overall, I think none of the predicates currently recommended by the SSSOM specification covers accurately the case of cross-species mappings, and I do think those mappings are significant enough to warrant being clearly identified as such instead of overloading a more ”generic” predicate the same way we already overloaded |
@gouttegd thank you for taking the time to write up this detailed line of argumentation! |
Copying some thoughts from slack: Biomappings (https://github.com/biopragmatics/biomappings) contains an ad-hoc relationship used between species-specific entities and their corresponding non-species-specific terms. In particular we used these when mapping between KEGG pathways (not species-specific) and reactome pathways (species specific). Not exactly what you said but in the same universe. Similarly, RO has several “homology” terms that could be a sub-relationship of a cross-species equivalence/similarity relationship that might (e.g., see https://www.ebi.ac.uk/ols/ontologies/ro/properties?iri=http%3A%2F%2Fpurl.obolibrary.org%2Fobo%2FRO_HOM0000017, though it’s a bit complicated to navigate the hierarchies for these) |
The worry on the one side (adding these cross species mappings) is mapping predicate proliferation. The question is, what other proliferations do we expect? Is it really that much of a worry? Another problem is that most users wont care and wont know about the difference between skos:exactMatch and OMO:12090908 (“cross-species exact match”). Is the precision really worth the confusion (they will have to “know” what to look for to get these!). Charlies dbxref argument on slack is not quite right because either way, we will maintain precision (exact, narrow, broad). Downside of using skos is that data transformations and clique merging could look a bit odd for some users (think multi hop queries in OXO). I could see a solution where we allow both kinds. or. us. gasp. gaaaaasp. the predicate_modifier column that we got. |
Having skimmed @cmungall 's reference long enough to know I don't have time to master it, I offer this. Two generalities emerge: (1) In countless pairs of hierarchies, different parents have almost-identical children. Wheels on bikes or tanks; children of people or dogs; roofs on houses or cars. Depending on the goal of the inferencing, having a purpose-built equivalent of exact match and close match (or any relation) in each domain may or may not be useful. (2) Using subclasses of relations to provide better precision always comes with a potential cost as @matentzn points out; ideally the tooling overcomes that costs by supporting generalized and specific searching by following the appropriate properties (appropriately) for the user's needs. However, I see this is one of the bigger unmet challenges in practical use of semantic content: enabling users to find good (yet appropriately rigorous) matches for their purpose. In other words, I don't think there's exactly one right answer here. |
One precision, since homologies have been mentioned. The cross-species mappings we would like to specify using the newly requested properties do not necessarily represent homologies, and we do not want to state that they are. In fact I used the words “equivalent” and “near-equivalent” in my request precisely to avoid talking about “homologies”. Of course, some of the terms we would like to map undoubtedly represent cases of homology. But there would also be several cases where we do not necessarily know the underlying evolutionary link, if any. |
Regarding the problem of “mapping predicate proliferation”: I am not sure I understand what the concerns are exactly. If the worry is that we could end up with dozens or hundreds of mapping properties, and that this would result in needless confusion:
|
We need to remember that |
First, maybe that’s not a bad thing. Maybe this question should be raised anyway. (Instead of hiding it under the rug by using Second, actually I don’t see how this request would necessarily lead to that question. I don’t want to use |
Could we gather more opinions and try moving this issue forward? I’d like to explain again my position by trying an analogy with a domain completely different from biology. Let’s say you’re doing comparative law and you want to map legal texts from different countries and/or epochs. For example, you want to map the USA’ Roe v. Wade (1973) with the UK’s Abortion Act (1967) and with France’s Veil Law (1975). All three texts can be said to be kind of “equivalent”, in that they roughly fulfil the same purpose in their respective legal systems: they make it legal to have an abortion.¹ That said, should they be mapped with
Using Could we use I would thus argue that comparative law scholars should use a specific relation (which could be called I believe cross-species mappings are of the same kind. They map entities that are clearly different but that are “equivalent” in the boundaries of their respective species. A fly neuron is not the same as a mouse neuron, but it does roughly the same thing in a fly brain as a mouse neuron does in a mouse brain. I believe this warrants using a specific relation, instead of overloading generic relations such as ¹ I apologise for picking an example that may be seen as controversial. I picked it solely because, not being a law scholar, there are not many laws for which I know the equivalents in other countries… ^^' |
@cmungall one option would be to create a coherent hierarchy of mapping relations in https://github.com/mapping-commons/semantic-mapping-vocabulary |
@gouttegd I don't think there is any issue with the conclusion the skos:exactMatch is not appropriate, and skos:relatedMatch is not very helpful. This is in the nature of SKOS properties—they are very general. The challenge is the modeling work that is required to agree on a new property, even in the limited SKOSy world of general relations. To define a new property, I suspect one needs to be: fairly precise in its definition to make the consistent application of that property unambiguous to all users, including defining transitivity, invertability, and other characteristics of the property; fairly convincing that this is a commonly needed property worthy of making IAO more complex and not leading down a slope of many other properties; and finding a name for the property that gets general agreement. Of these, the one I think would be most helpful is to describe your property more precisely than either the original proposal or the legal example does. What property exactly would you propose, and to which cross-species mappings will it apply or not apply? e.g., does 'equivalent' mean functional equivalence, genetic equivalence, behavioral equivalence, homologous (is that the right word?), all of the above? If it applies to any concept in a taxonomic ontology (pretty broad category, no?) then it's hard to immediately grok what it means across all different entities you might come across, and how similar something should be to apply it. (Or declare that it's a user judgment kind of assessment, like closeMatch. Which I might have used for the legal example, depending on the purpose of my mapping.) |
I think @matentzn's idea to mint a new property in SEMAPV is the most practical solution. We can use this property to mean exactly what we need to solve this problem, then potentially work on the "ontologization" of that property later, if there's a real need for it. |
It was not clear to me that there was an agreement on that. If there is, good.
All right, I can try. For my use-case (I maintain the mappings between FBbt and Uberon/CL), what I need is an annotation property which could be called For which mappings such a property should be used? Practical and immediate answer: all mappings for which we are currently using Can we define more precise rules as to when I understand this is not ideal, but I‘d like to point out that until now, Uberon/CL curators have been making this kind of judgment calls when deciding whether to use a
In this proposal, “equivalent” (if we stick to this choice of term) would not imply any knowledge about how the cell types or anatomical structures are equivalent. Maybe this could be refined later using sub-properties for each type of equivalence (to be used when we do know exactly how the structures are “equivalent”), but this would probably warrant further discussion, especially since many people seem concerned about property proliferation. Of note: all of the above is regarding “my” use case (Uberon/CL to species-specific mappings). There may be other use cases for other people (e.g., in the Slack chat @matentzn mentioned something about mappings such as |
Perhaps it is easier to list the various use cases we want to group. Core cases:
Is this core sufficient, or should we extend, if so with what? |
Closing as the new mapping relations have found their way into the SEMAPV vocabulary. |
We need some new properties to represent mappings between equivalent (or near-equivalent) terms across species.
That is, to be able to state:
Those properties could then replace the
oboInOwl:hasDbXref
property which is currently used for that (among other things). They could also be used as the mapping predicate in SSSOM-style mappings.How many nuances of “near-equivalent” do we allow is to be discussed, along with the exact labels to use. For the record, here is @dosumis’ proposition from a few months ago:
Tagging @matentzn to join the discussion.
The text was updated successfully, but these errors were encountered: