Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update angular v16 #41

Merged
merged 21 commits into from
Oct 30, 2023
Merged

Update angular v16 #41

merged 21 commits into from
Oct 30, 2023

Conversation

alecarn
Copy link
Collaborator

@alecarn alecarn commented Aug 2, 2023

Un preview de la mise à jour:

  • Upgrade Angular to v15 and v16
  • Upgrade Angular material to MDC based
  • Refact the styles with the latest IGO2-LIB styles system
  • Styles adjustment

Pour tester:

  • npm ci dans igo2-quebec
  • Aller dans igo2-lib
  • Checkout de la branche next
  • npm ci
  • npm run build.libs
  • Copier le dossier de distribution de la lib dans igo2-quebec/node_modules/igo2
  • Lancer un npm run start dans igo2-quebec
    Il est important de suivre l'ordre parce que si on relance une installation après avoir copié la librairie nous allons réinstaller la dernière version officielle de igo2-lib ce qu'on ne veut pas.

@alecarn alecarn requested review from LAMM26 and mneige August 2, 2023 17:23
@LAMM26
Copy link
Collaborator

LAMM26 commented Aug 10, 2023

Mostly seems to be ok, except a few styling differences and already broken features compared to the previous version:

Header

Title ("IGO") is too large/bold
"Nous joindre" is too large/bold
"Nous joindre" is not centered vertically when in mobile mode

Menu

Offset of text in buttons/options is too high vertically.

Footer

When the footer is deactivated, a scroll bar appears on the map

Map

Legend button text is too large/bold

Search

Title ("Résultats de recherche") doesn't have the correct font/color.
Results don't have the correct font/color
Scroll bar is not stylized (see correct style in mobile)

Get Info
Title is not centered in side panel/bottom panel
Scroll bar is no stylized (see correct style in mobile)
Side pannel doesn't appear when screen size is somewhere between mobile and desktop.

Config
"legendInPanel": false doesn't seem to work

@alecarn alecarn removed the request for review from mneige September 25, 2023 17:26
@alecarn alecarn self-assigned this Sep 25, 2023
@alecarn alecarn merged commit e927e8d into next Oct 30, 2023
3 checks passed
@alecarn alecarn deleted the update-angular-v15 branch October 30, 2023 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants