Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(directions): added possibility to toggle between two routing sources #1150

Merged
merged 1 commit into from
May 16, 2024

Conversation

LAMM26
Copy link
Contributor

@LAMM26 LAMM26 commented Mar 4, 2024

Please check if the PR fulfills these requirements

What is the current behavior? (You can also link to an open issue here)
At the moment, only one routing source can be used in the Directions tool.

What is the new behavior?
Two sources can now be used. In order to see the toggle to switch between the two, you need:

To be authenticated and authorized to use the second routing source.
Two routing sources that must be provided in the configs.
When the user activates the second/private source a message warns the user.

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[x] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications:

Other information:
See infra-geo-ouverte/igo2-lib#1644

@LAMM26 LAMM26 changed the base branch from master to next March 4, 2024 17:20
@LAMM26 LAMM26 marked this pull request as ready for review March 13, 2024 14:24
@LAMM26 LAMM26 requested a review from alecarn March 13, 2024 14:27
@LAMM26 LAMM26 self-assigned this Mar 13, 2024
@alecarn alecarn merged commit 6157df4 into next May 16, 2024
4 checks passed
@alecarn alecarn deleted the private_routing branch May 16, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants