Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(app): App installation is now configurable #929

Merged
merged 8 commits into from
Apr 24, 2023
Merged

feat(app): App installation is now configurable #929

merged 8 commits into from
Apr 24, 2023

Conversation

pelord
Copy link
Member

@pelord pelord commented Apr 20, 2023

Please check if the PR fulfills these requirements

What is the current behavior? (You can also link to an open issue here)
App was installable by default with the default manifest.
image

What is the new behavior?
Doc added.
By default, app is not installable.
By config (or environnement), this is possible to change the manifest and then, control the app behavior:

  • Installable
  • promoted (prompt to install android/windows on chrome/edge)

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[x] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications:

Other information:

@pelord pelord changed the title Dm feat(app): App installation is now configurable Apr 20, 2023
@pelord pelord merged commit 13b76fe into next Apr 24, 2023
@pelord pelord deleted the dm branch April 24, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant