Skip to content

fix(auth): delay PKCE callback shutdown briefly #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
owenrumney merged 1 commit into from
Jul 17, 2026
Merged

fix(auth): delay PKCE callback shutdown briefly #188

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion pkg/auth/pkce.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@ import (
"golang.org/x/oauth2"
)

const callbackServerShutdownDelay = time.Second

func (c *Config) PKCE(ctx context.Context) (oauth2.TokenSource, *oauth2.Token, error) {
caller, _ := events.GetMetadata[string]("caller")

Expand Down Expand Up @@ -75,8 +77,12 @@ func (c *Config) PKCE(ctx context.Context) (oauth2.TokenSource, *oauth2.Token, e
}

// We got the code (or at least a request), so we can stop the server.
// Using a goroutine to avoid deadlocking the handler.
// Use a short delay to give browsers time to finish rendering the
// localhost response before the listener closes; Firefox can otherwise
// report "Problem loading localhost" even though authentication succeeded.
// Using a goroutine avoids deadlocking the handler.
go func() {
time.Sleep(callbackServerShutdownDelay)
_ = server.Shutdown(context.Background())
}()
})
Expand Down
Loading