Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump google.golang.org/protobuf from 1.27.1 to 1.33.0 #130

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Mar 13, 2024

Bumps google.golang.org/protobuf from 1.27.1 to 1.33.0.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Mar 13, 2024
@vyzigold
Copy link
Contributor

Looks like something is broken in the tests. I'll take a look tomorrow.

@vyzigold
Copy link
Contributor

Regarding the CI I tried a few thing here: #131 , but I couldn't make it work. I discovered a slight bug in devstack introduced a few months ago, which is a part of the problem. I'll propose a fix for that upstream and maybe that'll fix our CI issues too.

@leifmadsen
Copy link
Member

@vyzigold do you suggest this be held back until fixes in CI can be resolved, or merge this down as-is?

Copy link
Contributor

@vkmc vkmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vyzigold is there a fix for devstack already available? If so please share so we can review and get this merged. Thanks!

@vyzigold
Copy link
Contributor

Missed the comments. Sorry. The fix was merged yesterday. I'm restarting the failed jobs.

@vyzigold
Copy link
Contributor

I can't see the button to rerun the jobs for some reason. I'll have the dependabot rebase or recreate the PR to rerun them.

@vyzigold
Copy link
Contributor

@dependabot rebase

Copy link
Contributor Author

dependabot bot commented on behalf of github Apr 17, 2024

Looks like this PR is already up-to-date with master! If you'd still like to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

@vyzigold
Copy link
Contributor

@dependabot recreate

Bumps google.golang.org/protobuf from 1.27.1 to 1.33.0.

---
updated-dependencies:
- dependency-name: google.golang.org/protobuf
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the 7dbedependabot/go_modules/google.golang.org/protobuf-1.33.0 branch from ea57a57 to 51d15bd Compare April 17, 2024 05:33
@vkmc vkmc self-requested a review April 17, 2024 07:43
@vkmc vkmc merged commit 873b823 into master Apr 17, 2024
18 checks passed
@vkmc vkmc deleted the 7dbedependabot/go_modules/google.golang.org/protobuf-1.33.0 branch April 17, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Development

Successfully merging this pull request may close these issues.

4 participants