Fix CI workflow failures#287
Open
detrin wants to merge 2 commits into
Open
Conversation
Replace @master refs with pinned versions to fix startup failures.
Prevents mypy from scanning site-packages, which fails when installed packages use syntax newer than python_version = 3.9.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #281. Partially addresses #282.
Two changes:
1. Pin GitHub Actions to stable versions
actions/checkout@masterandactions/setup-python@masterno longer resolve, causingstartup_failureon all PRs. Pinned to@v4/@v5. Also updatedcodecov/codecov-actionfrom v1 to v4.2. Scope mypy pre-commit hook to probatus/ only
mypy was scanning site-packages, failing on
matchstatements in pytest internals becausepython_version = "3.9". Addedfiles: ^probatus/to the hook.Verified on fork: https://github.com/detrin/probatus/actions/runs/23989798509 - CI starts and passes linting. Remaining test failures are pre-existing SHAP/XGBoost incompatibility.