-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] l10n_ar_edi_ux: We consider whether the surname or first name data is empty #363
base: 16.0
Are you sure you want to change the base?
Conversation
39f8e54
to
f95b118
Compare
f95b118
to
88a05a3
Compare
8c3e565
to
9fed904
Compare
#Limpiamos los diccionarios para quitarle los valores None | ||
if dictionary and type(dictionary) == dict: | ||
for val in dictionary: | ||
dictionary[val] = type_replace if not dictionary[val] else dictionary[val] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only check the element, and replace it with the type_replace that match if None
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here we take the dictionary and really check if it has any None element, if it is None we replace it.
self._clean_dict(data_rg.get("categoriaMonotributo"), type_replace={}) | ||
cat_mt = data_mt.get("categoriaMonotributo", {}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to remove second line, cat_mt = elf._clean_dict(data_rg.get("categoriaMonotributo"), type_replace={})
self._clean_dict(data_mt.get("actividadMonotributista"), type_replace=[]) | ||
data_mt_actividades = data_mt.get("actividadMonotributista", []) or [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fusionar
l10n_ar_edi_ux/models/res_partner.py
Outdated
self._clean_dict(data_mt.get("impuesto"), type_replace=[]) | ||
import pdb | ||
pdb.set_trace() | ||
self._clean_dict(data_rg.get("impuesto"), type_replace=[]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
esta repetido
self._clean_dict(data.get("domicilioFiscal"), type_replace={}) | ||
domicilio = data.get("domicilioFiscal", {}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fusionar
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
_clean_dict does not return anything, check if the dictionary had a None value and replace it. What do you mean by fusion?
9fed904
to
cee24b1
Compare
Task: 29136