[FIX] l10n_ar_edi_ux: We consider whether the surname or first name data is empty #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mem-adhoc
force-pushed
the
16.0-t-29136-mem
branch
2 times, most recently
from
39f8e54
to
f95b118
Compare
mem-adhoc
force-pushed
the
16.0-t-29136-mem
branch
from
f95b118
to
88a05a3
Compare
mem-adhoc
force-pushed
the
16.0-t-29136-mem
branch
2 times, most recently
from
8c3e565
to
9fed904
Compare
zaoral
suggested changes
Jul 12, 2024
| #Limpiamos los diccionarios para quitarle los valores None | ||
| if dictionary and type(dictionary) == dict: | ||
| for val in dictionary: | ||
| dictionary[val] = type_replace if not dictionary[val] else dictionary[val] |
There was a problem hiding this comment.
only check the element, and replace it with the type_replace that match if None
There was a problem hiding this comment.
Here we take the dictionary and really check if it has any None element, if it is None we replace it.
Comment on lines
+149
to
147
| self._clean_dict(data_rg.get("categoriaMonotributo"), type_replace={}) | ||
| cat_mt = data_mt.get("categoriaMonotributo", {}) |
There was a problem hiding this comment.
need to remove second line, cat_mt = elf._clean_dict(data_rg.get("categoriaMonotributo"), type_replace={})
Comment on lines
+100
to
98
| self._clean_dict(data_mt.get("actividadMonotributista"), type_replace=[]) | ||
| data_mt_actividades = data_mt.get("actividadMonotributista", []) or [] |
l10n_ar_edi_ux/models/res_partner.py
Outdated
| self._clean_dict(data_mt.get("impuesto"), type_replace=[]) | ||
| import pdb | ||
| pdb.set_trace() | ||
| self._clean_dict(data_rg.get("impuesto"), type_replace=[]) |
Comment on lines
+86
to
87
| self._clean_dict(data.get("domicilioFiscal"), type_replace={}) | ||
| domicilio = data.get("domicilioFiscal", {}) |
There was a problem hiding this comment.
_clean_dict does not return anything, check if the dictionary had a None value and replace it. What do you mean by fusion?
mem-adhoc
force-pushed
the
16.0-t-29136-mem
branch
from
9fed904
to
cee24b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task: 29136