Fix read loop infinite loop when EOF received #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dwwoelfel I've tested this against your reproducer and it seems to resolve the issue. Can you confirm that? |
|
This worked for me! I still get an empty reply from the server if I send a header that is too large, though. A large referrer header is how I initially discovered the problem. I hadn't found a way to fix it in my patch, either. |
|
@dwwoelfel That sounds like an instance of #18. If not, could you open another issue for that? |
Merged
|
WRT #18, is there some way we can return a 413 easily, rather than an empty reply? |
Lupus
pushed a commit
to Lupus/httpaf
that referenced
this pull request
Dec 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #68, subsumes #69.