-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
STS: add support for signing requests with assume_role
tokens
#117
Conversation
…template functionality to match opam-dune-lint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall the changes look good. A couple of things to fixup and could you add a line into CHANGES.md describing the work and link to this PR.
Thank you for the contribution. :-)
|
||
match access_key, secret_key, region with | ||
| Some access_key, Some secret_key, Some region -> | ||
run_test_tt_main (suite { access_key; secret_key; region }) | ||
run_test_tt_main (suite { access_key; secret_key; region; role_arn }) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice thanks for adding that test.
Thanks @zbaylin @UnrealAkama @bleepbloopsify |
This supersedes #95.
It includes the ability to sign AWS requests with
assume_role
tokens, and has other various fixes, such as fixing the way dune test files are generated if extra libraries are needed.