Update buckifier and TARGETS

Summary: Some flags used via make were not applied in the buckifier/targets file, causing some failures to be missed by testing infra ( ie the one fixed by facebook#3434 ) Closes facebook#3452 Differential Revision: D7457419 Pulled By: gfosco fbshipit-source-id: e4aed2915ca3038c1485bbdeebedfc33d5704a49
inikep · Mar 30, 2018 · d9bfb35 · d9bfb35
1 parent c3eb762
commit d9bfb35
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/TARGETS b/TARGETS
@@ -25,6 +25,10 @@ rocksdb_compiler_flags = [
     "-DTBB",
     # Needed to compile in fbcode
     "-Wno-expansion-to-defined",
+    # Added missing flags from output of build_detect_platform
+    "-DROCKSDB_PTHREAD_ADAPTIVE_MUTEX",
+    "-DROCKSDB_BACKTRACE",
+    "-Wshorten-64-to-32",
 ]
 
 rocksdb_external_deps = [

diff --git a/buckifier/targets_cfg.py b/buckifier/targets_cfg.py
@@ -29,6 +29,10 @@
     "-DTBB",
     # Needed to compile in fbcode
     "-Wno-expansion-to-defined",
+    # Added missing flags from output of build_detect_platform
+    "-DROCKSDB_PTHREAD_ADAPTIVE_MUTEX",
+    "-DROCKSDB_BACKTRACE",
+    "-Wshorten-64-to-32",
 ]
 
 rocksdb_external_deps = [