A normal macro for loading env vars and stuff I guess #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prestwich
force-pushed
the
prestwich/from-env-macro
branch
from
8062790 to
210577f
Compare
prestwich
force-pushed
the
prestwich/from-env-macro
branch
from
210577f to
cc31fed
Compare
Evalir
reviewed
Apr 29, 2025
Comment on lines
+105
to
+114
| pub(crate) fn field_name(&self, idx: usize) -> Ident { | ||
| if let Some(field_name) = self.field_name.as_ref() { | ||
| return field_name.clone(); | ||
| } | ||
|
|
||
| let n = format!("field_{}", idx); | ||
| syn::parse_str::<Ident>(&n) | ||
| .map_err(|_| syn::Error::new(self.span, "Failed to create field name")) | ||
| .unwrap() | ||
| } |
There was a problem hiding this comment.
Right, so for tuple structs, we'd get instead of the struct prop name, field_0, field_1...,field_n and so forth? This seems fine to me to support tuple structs although I'm not sure in which cases you'd want to do a config with a tuple struct.
| use init4_from_env_derive::FromEnv; | ||
|
|
||
| #[derive(FromEnv, Debug)] | ||
| pub struct FromEnvTest { |
There was a problem hiding this comment.
we should probably add a test with a tuple struct.
Evalir
reviewed
Apr 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.