Parallel Workers#40
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked PR over #39
File system processing admits a fair bit of isolated parallelism. In this PR, we spin up 8 workers to avoid bottlenecking a single thread on things like Automerge doc materialisation:
Notice that the serial version is superlinear, due to thread contention preventing async IO from running (because of JS runtime lifecycle).
This uses a fairly naive round-robin strategy instead of work stealing or worker-per-tasks something. The number of workers is fixed up front, so that's a separate scaling factor. Here's different workers for 1000 x 32 KB docs:
Of course much larger or much smaller file systems would perform differently. There's some argument to be made to dynamically scale but also probably YAGNI. Also recall that parallelism can also have its own contention leading to paradoxical slowdowns, so a conservative choice like 8 is probably good for most situations. At our scale, 8 seems reasonable, about 4k files moving higher seems to help but we don't tend to sync >4k docs at a time AFAIK