-
Notifications
You must be signed in to change notification settings - Fork 111
fix: regenerate agents-mcp package with pnpm monorepo compatibility #2770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 5 commits
61a285d
34b67c9
3681127
fcf22e8
5dbc3c2
21db81d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@inkeep/agents-mcp": patch | ||
| --- | ||
|
|
||
| Regenerate MCP server from latest OpenAPI spec with pnpm monorepo compatibility fixes |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| package.json | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,7 +3,10 @@ | |
| !/**/*.ts | ||
| !/**/*.js | ||
| !/**/*.mjs | ||
| !/**/*.json | ||
| !/package.json | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The narrowing from |
||
| !/jsr.json | ||
| !/dist/**/*.json | ||
| !/esm/**/*.json | ||
| !/**/*.map | ||
|
|
||
| /eslint.config.mjs | ||
|
|
||
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -14,6 +14,7 @@ generation: | |
| securityFeb2025: true | ||
| sharedErrorComponentsApr2025: true | ||
| sharedNestedComponentsJan2026: true | ||
| nameOverrideFeb2026: false | ||
| auth: | ||
| oAuth2ClientCredentialsEnabled: true | ||
| oAuth2PasswordEnabled: true | ||
|
|
@@ -23,6 +24,7 @@ generation: | |
| schemas: | ||
| allOfMergeStrategy: shallowMerge | ||
| requestBodyFieldName: body | ||
| versioningStrategy: automatic | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 💭 Consider: Issue: The Why: This may cause version drift between what Speakeasy expects and what's in the manually-managed Fix: Consider removing Refs: |
||
| persistentEdits: | ||
| enabled: "true" | ||
| tests: | ||
|
|
@@ -50,3 +52,4 @@ mcp-typescript: | |
| outputModelSuffix: output | ||
| packageName: '@inkeep/agents-mcp' | ||
| responseFormat: envelope | ||
| validateResponse: false | ||
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is correct — prevents Speakeasy from overwriting the manually-managed
package.jsonwith its own template that lacks the pnpm-specific adjustments. However, this means future dependency additions from Speakeasy regeneration (e.g., if a new SDK feature requires a new package) will need manual intervention. Consider documenting this in a comment or the README's generation instructions so future regenerators know to diff the generatedpackage.jsonagainst the existing one.