-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added unknown docs #6839
Open
sanderr
wants to merge
7
commits into
master
Choose a base branch
from
docs/6056-unknown-docs
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
added unknown docs #6839
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
5410d84
added unknown docs
sanderr ddf69d1
Merge remote-tracking branch 'origin/master' into docs/6056-unknown-docs
sanderr 6f5dcd8
Apply suggestions from code review
sanderr 35a58d3
updated destination branches
sanderr cb612fa
review comment
sanderr 7cd7196
updated snippet
sanderr 73639d1
review comment
sanderr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
description: Added documentation about unknowns | ||
change-type: patch | ||
sections: | ||
minor-improvement: "{{description}}" | ||
issue-nr: 6056 | ||
destination-branches: | ||
- master | ||
- iso8 | ||
- iso7 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,49 +1,48 @@ | ||
.. _model_export_format: | ||
Model Export Format | ||
======================== | ||
|
||
|
||
|
||
|
||
#. top level is a dict with one entry for each instance in the model | ||
#. the key in this dict is the object reference handle | ||
#. the value is the serialized instance | ||
#. the serialized instance is a dict with three fields: type, attributes and relation. | ||
#. type is the fully qualified name of the type | ||
#. attributes is a dict, with as keys the names of the attributes and as values a dict with one entry. | ||
#. An attribute can have one or more of tree keys: unknows, nones and values. The "values" entry has as value a list with the attribute values. | ||
If any of the values is Unknown or None, it is removed from the values array and the index at which it was removed is recorded in respective the unknowns or nones value | ||
#. relations is like attributes, but the list of values contains the reference handles to which this relations points | ||
#. An attribute can have one or more of tree keys: unknows, nones and values. The "values" entry has as value a list with the attribute values. | ||
If any of the values is :term:`unknown` or None, it is removed from the values array and the index at which it was removed is recorded in respective the unknowns or nones value | ||
#. relations is like attributes, but the list of values contains the reference handles to which this relations points | ||
|
||
Basic structure as pseudo jinja template | ||
Basic structure as pseudo jinja template | ||
|
||
.. code-block:: js+jinja | ||
|
||
{ | ||
{% for instance in instances %} | ||
'{{instance.handle}}':{ | ||
"type":"{{instance.type.fqn}}", | ||
"attributes":[ | ||
"attributes":[ | ||
{% for attribute in instance.attributes %} | ||
"{{attribute.name}}": [ {{ attribute.values | join(",") }} ] | ||
{% endfor %} | ||
] | ||
"relations" : [ | ||
{% for relation in instance.relations %} | ||
"{{relation.name}}": [ | ||
"{{relation.name}}": [ | ||
{% for value in relation.values %} | ||
{{value.handle}} | ||
{% endfor %} | ||
] | ||
{% endfor %} | ||
] | ||
|
||
{% endif %} | ||
} | ||
} | ||
|
||
Type Export Format | ||
======================== | ||
|
||
.. automodule:: inmanta.model | ||
:members: | ||
:private-members: | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my opinion on this is known. I would like to still have this power, but I leave it to you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By now the behavior is no longer under discussion, it's simply about documenting it. I'll double check this now.