drop tox and implement new development flow#8667
Merged
Conversation
Contributor
Author
|
Note to self: general reception was positive, make this actionable. |
Contributor
Author
Contributor
Author
|
Closing for now, taking this up as part of a larger dependency epic sometime this year |
sanderr
commented
Apr 24, 2025
Comment on lines
+100
to
+102
| %/bin/python: % | ||
| $(PYTHON) -m venv $? | ||
| $(eval PYTHON=$@) |
Contributor
Author
There was a problem hiding this comment.
This may be somewhat unconventional, I'm honestly not sure.
| # Download bare necessities | ||
| CommandRunner(logging.getLogger(__name__)).run_command_and_log_output( | ||
| ["pip", "download", "setuptools", "wheel"], cwd=build_dir | ||
| [sys.executable, "-m", "pip", "download", "setuptools", "wheel"], cwd=build_dir |
Contributor
Author
There was a problem hiding this comment.
This is just a bugfix for something that happened to surface.
sanderr
changed the title
sanderr
changed the title
jptrindade
approved these changes
Apr 24, 2025
arnaudsjs
approved these changes
Apr 24, 2025
sanderr
commented
Apr 24, 2025
Contributor
Author
|
@arnaudsjs re-requesting review for the latest commit. It fixes a bug in the parsetab generation for non-editable installs. The |
arnaudsjs
approved these changes
Apr 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
If approved, I'll apply this to all extension repos, and to all dev branches.
Requires inmanta/irt#2429
Related Slack thread: https://inmanta.slack.com/archives/CKRF0C8R3/p1745483532991769
Self Check:
Strike through any lines that are not applicable (
~~line~~) then check the box