Issue/2025 01 24 update quickstart docs #8693
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ype-for-every-plugin
sanderr
reviewed
Jan 31, 2025
| @@ -96,6 +96,7 @@ Go to the `SR Linux` folder and then `containerlab` to spin-up the containers: | |||
|
|
|||
| cd examples/Networking/SR\ Linux/containerlab | |||
| sudo docker pull ghcr.io/nokia/srlinux:latest | |||
| sudo docker pull ghcr.io/inmanta/orchestrator:latest | |||
There was a problem hiding this comment.
I don't know about this one. I'm not sufficiently familiar with the containers to review this part.
There was a problem hiding this comment.
@bartv wdyt ?
For reference this is the corresponding topology file https://github.com/inmanta/examples/blob/master/Networking/SR%20Linux/containerlab/topology.yml
There was a problem hiding this comment.
The image looks good, but I am not sure why we are pulling it here, containerlab will do it too
Hugo-Inmanta
requested review from
bartv and
edvgui
and removed request for
bartv
edvgui
reviewed
Feb 5, 2025
| @@ -253,7 +253,7 @@ The following command executes a script to copy the required resources to a spec | |||
|
|
|||
| .. code-block:: | |||
| $ docker exec -ti -w /code clab-srlinux-inmanta-server /code/setup.sh | |||
| $ docker exec -ti -w /code clab-srlinux-inmanta-server /code/setup.sh <environment uuid> | |||
There was a problem hiding this comment.
Does this code setup still work with the new disk layout?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes Add ticket reference here
Self Check:
Strike through any lines that are not applicable (
~~line~~) then check the box