INN-2310: Implement step.sendEvent #21
Conversation
KiKoS0
requested review from
djfarrelly,
darwin67,
jpwilliams and
tonyhb
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
ktlint
inngest-test-server/src/main/kotlin/com/inngest/App.kt|56 col 11| Property name should use the screaming snake case notation when the value can not be changed
KiKoS0
force-pushed
the
implement-send-event
branch
from
007eb3a to
3eb4eb1
Compare
It has two signatures to handle both a single event or an array of events.
KiKoS0
force-pushed
the
implement-send-event
branch
from
3eb4eb1 to
b229b33
Compare
albertchae
changed the title
| fun sendEvent( | ||
| id: String, | ||
| events: Array<InngestEvent>, | ||
| ) { |
There was a problem hiding this comment.
the return type should be similar to send itself.
https://www.inngest.com/docs/reference/functions/step-send-event#step-send-event-id-event-payload-event-payload-promise-ids-string
There was a problem hiding this comment.
gotcha, I'll address them in this PR 👍
There was a problem hiding this comment.
Turns out this is a bit tricky, we left a TODO to investigate later
| return | ||
| } catch (e: StateNotFound) { | ||
| val response = CommHandler.sendEvent<SendEventsResponse>(events) | ||
| throw StepInterruptSendEventException(id, hashedId, response!!.ids) |
There was a problem hiding this comment.
minor, let's see if we can change the return type of CommHandler.sendEvent to guarantee non null response
There was a problem hiding this comment.
we'll investigate this later too
Add support for
step.sendEventto send events out.Introduces a small refactor to the
CommHandlerhttp client to dry out API calls.