Add version to jar manifest and read at runtime for SDK version header #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add version to build.gradle.kts - create a version properties file at build time that can be read in app Following example from https://stackoverflow.com/a/70088083
https://docs.gradle.org/current/samples/sample_building_kotlin_libraries.html#customize_the_library_jar https://stackoverflow.com/a/43065467 Add getVersion to a companion object on `Version`, which I believe means the version should only be read from the manifest file once.
albertchae
requested review from
djfarrelly,
darwin67,
jpwilliams and
tonyhb
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add version to the jar manifest and read from that to send the SDK version header
https://docs.gradle.org/current/samples/sample_building_kotlin_libraries.html#customize_the_library_jar
https://stackoverflow.com/a/43065467
To avoid unnecessarily reading from the manifest file, we store the value in a companion object which
should have the effect of making it a singleton.
An alternative using java properties was considered based on https://stackoverflow.com/a/70088083, but
the jar manifest seems more appropriate