Cleanup the Inngest's client send interface
#69
Conversation
KiKoS0
requested review from
djfarrelly,
darwin67,
jpwilliams and
tonyhb
as code owners
KiKoS0
force-pushed
the
riadh/inn-2815-send-multiple-events
branch
from
6c31189 to
fdddaea
Compare
| fun send(events: Array<InngestEvent>): SendEventsResponse? { | ||
| val request = httpClient.build("$baseUrl/e/$eventKey", events) | ||
|
|
||
| return httpClient.send(request) lambda@{ response -> | ||
| // TODO: Handle error case |
There was a problem hiding this comment.
We can handle the error case in: #57
Making it clearer that it supports sending multiple events at once.
KiKoS0
force-pushed
the
riadh/inn-2815-send-multiple-events
branch
from
fdddaea to
0fc1ebf
Compare
| @@ -206,23 +206,22 @@ class Step( | |||
| } | |||
|
|
|||
| /** | |||
| * Sends multiple events to Inngest | |||
| * Sends a single event to Inngest. | |||
There was a problem hiding this comment.
nice catch on the docs here
| * @param events The events to send. | ||
| * | ||
| */ | ||
| fun send(events: Array<InngestEvent>): SendEventsResponse? { |
There was a problem hiding this comment.
Hm, I can't find a concrete reference for this but I think Kotlin Array is the equivalent of a java array, which means InngestEvent[] which I think tends to be less flexible than the List interface, since that has multiple implementations and [] arrays can easily be made into ArrayList
Some SO posts that seem to align with that I'm saying, but nothing definitive
There was a problem hiding this comment.
let's address this in a follow up
| * @param event The event to send. | ||
| * | ||
| */ | ||
| fun send(event: InngestEvent): SendEventsResponse? = send(arrayOf(event)) |
There was a problem hiding this comment.
do other SDKs use the plural response type even if a singular event is sent?
| @@ -21,37 +19,28 @@ class Inngest | |||
|
|
|||
| internal val httpClient = HttpClient(RequestConfig(headers)) | |||
|
|
|||
| inline fun <reified T> send(payload: Any): T? = | |||
There was a problem hiding this comment.
oh nice, we can get rid of the reified type
Summary
Cleanup the Inngest's client
sendinterface, making it clearer that it supports sending multiple events at once.Changes:
sendEventmethod.sendmethod and cleanup the implementation: Removed the unnecessary generic andAnytyping.Checklist
Related