Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration test for step.invoke #78

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

KiKoS0
Copy link
Collaborator

@KiKoS0 KiKoS0 commented Sep 8, 2024

Summary

Creates a new integration test for step.invoke. An error case is also covered by:

public String execute(FunctionContext ctx, Step step) {
try {
step.invoke(
"failing-function",
"spring_test_demo",
"non-retriable-fn",
new LinkedHashMap<String,
String>(),
null,
Object.class);
} catch (StepError e) {
return e.getMessage();
}
return "An error should have been thrown and this message should not be returned";
}

Checklist

  • Update documentation
  • Added unit/integration tests

Related

@KiKoS0 KiKoS0 requested a review from albertchae September 8, 2024 19:49
@KiKoS0 KiKoS0 self-assigned this Sep 8, 2024
Copy link

linear bot commented Sep 8, 2024

Copy link
Collaborator

@albertchae albertchae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

}};

return step.invoke(
"failing-function",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this step name copy pasta?

@KiKoS0 KiKoS0 force-pushed the riadh/inn-3359-add-integration-test-for-step-invoke branch from b4c4259 to 952d14f Compare September 11, 2024 23:31
@KiKoS0 KiKoS0 force-pushed the riadh/inn-3359-add-integration-test-for-step-invoke branch from 952d14f to b0609b7 Compare September 11, 2024 23:34
@KiKoS0 KiKoS0 merged commit 0d4e9c0 into main Sep 11, 2024
9 checks passed
@KiKoS0 KiKoS0 deleted the riadh/inn-3359-add-integration-test-for-step-invoke branch September 11, 2024 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants