Fix is_unique_ip() logic #388
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TuxPowered42
force-pushed
the
k_fix_is_unique_ip_logic
branch
2 times, most recently
from
bd3e188 to
c9fb976
Compare
kofrezo
reviewed
Mar 10, 2025
lamaral
reviewed
Mar 10, 2025
TuxPowered42
force-pushed
the
k_fix_is_unique_ip_logic
branch
from
c297982 to
05ed0e3
Compare
TuxPowered42
force-pushed
the
k_fix_is_unique_ip_logic
branch
4 times, most recently
from
09a43f5 to
6ba4032
Compare
kofrezo
approved these changes
Mar 10, 2025
TuxPowered42
force-pushed
the
k_fix_is_unique_ip_logic
branch
2 times, most recently
from
a077946 to
dcdd702
Compare
We allow Servers to have various inet attribute types which configure behaviour of checking for IP address conflics. Type "loadbalancer" does not have an uniqueness check, type "network" only checks within the same servertype. Ensure that the uniqueness of IP address is checked symmetrically: "host" inet attribute type must not ensure its uniqueness against "network" and "loadbalancer", because they don't check against "host". For example it was possible to create a domain object for IP address of a VM, but it was impossible to create a VM once a domain existed. Improve the message shown to user in case of conflict.
TuxPowered42
force-pushed
the
k_fix_is_unique_ip_logic
branch
from
dcdd702 to
6ea732e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.