Conversation
…lled to allow for groups, update description of ENV_FILE_DATA
tyrann0us
reviewed
Feb 4, 2025
Member
tyrann0us
left a comment
tyrann0us
left a comment
There was a problem hiding this comment.
Thanks for working on this! Left a couple of relatively minor comments and suggestions. 😉
1 task
tyrann0us
reviewed
Feb 5, 2025
tyrann0us
approved these changes
Feb 6, 2025
Member
tyrann0us
left a comment
tyrann0us
left a comment
There was a problem hiding this comment.
Thank you for incorporating all the changes! 🙏🏽 There are only two very minor suggestions left that don't stop me from approving. Great job! 💪🏽
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature
What is the current behavior? (You can also link to an open issue here)
We miss a reusable workflow to run Playwright tests. Closes #173
What is the new behavior (if this is a feature change)?
Add a new workflow to run Playwright tests.
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No
Other information: