-
Notifications
You must be signed in to change notification settings - Fork 3
feat: add native asset decoding to tx_unpacker and store balances in utxo_state #140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: William Hankins <[email protected]>
Signed-off-by: William Hankins <[email protected]>
golddydev
reviewed
Sep 3, 2025
…rsion Signed-off-by: William Hankins <[email protected]>
golddydev
approved these changes
Sep 3, 2025
Signed-off-by: William Hankins <[email protected]>
sandtreader
requested changes
Sep 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great generally - just concern about use of expect() and would like unit tests extended too.
Signed-off-by: William Hankins <[email protected]>
Signed-off-by: William Hankins <[email protected]>
Signed-off-by: William Hankins <[email protected]>
…ets-in-utxo-deltas
All feedback has been implemented. Merging so that I can continue progress on #148. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces native asset decoding support in
tx_unpacker
and integrate it withutxo_state
storage.TxOutput
s now carry fullValue
s (lovelace + assets) instead of only lovelace. These are propagated through UTXODeltasMessage into ledger storage.Main changes:
Value
andValueDelta
types to represent balances:map_value()
intx_unpacker/src/map_parameters
to decode PallasMultiEraValue
intoValue
.TxOutput
to useValue
instead of a rawu64
./utxo_state/state.rs
to process and persist native asset vectors./utxo_state/rest.rs
to expose asset balances in REST responses.Memory usage benchmark (epoch 300):
main: 2.465 GB
this branch: 2.854 GB