feat: expand epochs state; impl pool's historical endpoints #173

golddydev · 2025-09-11T12:22:54Z

Module Refactoring: Epoch Activity Counter → Epochs State

Rename epoch_activity_counter to epochs_state since that module is not stateless and start storing state (e.g. block hashes).

Key Changes

Implemented BF Endpoints

/pools/{pool_id}/blocks: All block hashes minted by pool.
/pools/{pool_id}/updates: Pool's Update events (registered and deregistered)
/pools/{pool_id}/votes: History of Stake pool's votes.
/pools/{pool_id}: Pool's Detailed Information (only missing calidus_key against BF)

Fixes on several calculation

Pools Delegators: Updated it to only include (or sum) utxo_value of stake_keys.
DRep Delegators: Updated it to only include (or sum) utxo_value of stake_keys.

🆕 New Functionality & Data Structures

Pool Update Tracking: Added support for pool registration/retirement tracking with position information to spo_state (PoolRegistrationWithPos, PoolRetirementWithPos)
Pool Vote Tracking: Added support for pool's vote history tracking with position information to spo_state
Extended pool-related queries: Added new queries for:
- Optimal pool sizing (For pool saturation calculation - From accounts_state)
- Pool live stake information
- Accounts UTXO values mapping & sum (this is used for live_pledge)

Refactor SPO State

"Remove Aggregated State": Remove AggregatedSPOState (which only stores active_stakes) and instead rely on epochs_history for active_stakes.

New Common Types

BlockHash: Introduce new BlockHash type as [u8; 32]

… state - Replaced Vec<u8> with BlockHash type in BlockInfo for better type safety. - Added BlockHash type definition and HashTraits implementation. - Updated various modules to utilize the new BlockHash type, including state management and query responses. - Enhanced StoreConfig to support block hash storage configuration. - Adjusted tests to reflect changes in block hash handling.

- Removed unused GetPoolBlocks query from PoolsStateQuery. - Enhanced get_block_hashes method to return an empty vector instead of an Option. - Implemented pool blocks retrieval in handle_pool_blocks_blockfrost, including error handling for missing parameters and invalid pool IDs. - Added support for querying pool information and block hashes in the SPOState module.

…e tx_hash and cert_index

…nance message - Renamed and reorganized subscription topics for clarity and consistency. - Introduced governance subscription handling in the SPOState module.

- Added support for retrieving pool updates and votes in the SPOState module. - Updated PoolUpdates and PoolVotes structures to include relevant data. - Enhance serde for PoolUpdateEvent and VoteRecord

…expand-epochs-state

- Added new queries for retrieving pool live stake information and optimal pool sizing. - Implemented methods to get accounts' UTXO values and their sums. - Refactored existing code to improve clarity and maintainability.

whankinsiv

Overall this is good. I would prefer to see this PR broken up into 3 separate PRs with one for the epoch_state refactor, another for the expanded spo_state, and the third for the REST handling.

whankinsiv · 2025-09-15T18:00:36Z

modules/epochs_state/src/state.rs

+
+            if let Some(block_hashes) = self.block_hashes.as_mut() {
+                let block_hash: Option<BlockHash> = block
+                    .hash


block.hash should be converted to the BlockHash type in mithril_snapshot_fetcher.

whankinsiv · 2025-09-15T18:14:42Z

modules/epochs_state/src/state.rs

+
+    pub fn get_blocks_minted_data_by_pool(&self, vrf_key_hash: &KeyHash) -> (u64, u64) {
+        (
+            self.total_blocks_minted.get(vrf_key_hash).map(|v| *v as u64).unwrap_or(0),


Is v here not already u64?

whankinsiv · 2025-09-15T18:17:52Z

modules/accounts_state/src/state.rs

+
+        let total_supply =
+            shelly_params.max_lovelace_supply - self.rewards_state.mark.pots.reserves;
+        let nopt = shelly_params.protocol_params.stake_pool_target_num as u64;


Is this not already u64?

whankinsiv · 2025-09-15T18:20:16Z

modules/mithril_snapshot_fetcher/src/mithril_snapshot_fetcher.rs

                            slot,
                            number,
-                            hash: block.hash().to_vec(),
+                            hash: *block.hash(),


Convert to BlockHash type here as mentioned above.

whankinsiv · 2025-09-15T18:42:00Z

modules/spo_state/src/historical_spo_state.rs

            return None;
        };
-        Some(delegators.insert(delegator.clone()))
+        Some(delegators.insert(delegator.clone()).is_some())


This is incorrect, it should be

pub fn add_delegator(&mut self, delegator: &KeyHash) -> Option<bool> { self.delegators.as_mut().map(|d| d.insert(delegator.clone())) }

whankinsiv · 2025-09-15T18:42:26Z

modules/spo_state/src/historical_spo_state.rs

            return None;
        };
-        Some(delegators.remove(delegator))
+        Some(delegators.remove(delegator).is_some())


Same thing here, it should be

pub fn remove_delegator(&mut self, delegator: &KeyHash) -> Option<bool> { self.delegators.as_mut().map(|d| d.remove(delegator)) }

whankinsiv · 2025-09-15T18:47:15Z

modules/spo_state/src/state.rs

+    pub fn get_pool_votes(&self, pool_id: &KeyHash) -> Option<Vec<VoteRecord>> {
+        let Some(historical_spos) = self.historical_spos.as_ref() else {
+            return None;
+        };
+
+        let votes: Option<Vec<VoteRecord>> =
+            historical_spos.get(pool_id).map(|s| s.votes.clone()).flatten();
+        votes
+    }
+


This can be:

pub fn get_pool_votes(&self, pool_id: &KeyHash) -> Option<Vec<VoteRecord>> { self.historical_spos .as_ref()? .get(pool_id) .and_then(|s| s.votes.clone()) }

whankinsiv · 2025-09-15T18:48:04Z

modules/spo_state/src/state.rs

+    /// Get Pool Updates
+    pub fn get_pool_updates(&self, pool_id: &KeyHash) -> Option<Vec<PoolUpdateEvent>> {
+        let Some(historical_spos) = self.historical_spos.as_ref() else {
+            return None;
+        };
+
+        let updates: Option<Vec<PoolUpdateEvent>> =
+            historical_spos.get(pool_id).map(|s| s.updates.clone()).flatten();
+        updates
+    }


This can be:

pub fn get_pool_updates(&self, pool_id: &KeyHash) -> Option<Vec<PoolUpdateEvent>> { self.historical_spos .as_ref()? .get(pool_id) .and_then(|s| s.updates.clone()) }

whankinsiv · 2025-09-15T18:52:07Z

modules/upstream_chain_fetcher/src/upstream_chain_fetcher.rs

                            block.slot, block.number
                        );
-                        let point = Point::Specific(block.slot, block.hash.clone());
+                        let point = Point::Specific(block.slot, block.hash.to_vec());


This should be a fixed length type instead of a vec.

Yes, but this Point is from pallas

golddydev · 2025-09-16T16:25:25Z

Closing this PR favor of
#175
#177
#187

golddydev added 4 commits September 10, 2025 17:55

fix: make pool's delegators endpoint blockfrost-compatible

5da07f7

feat: add empty epochs_state module and update TxCerts type to includ…

262dba5

…e tx_hash and cert_index

golddydev changed the title ~~feat: expand epochs state~~ feat: expand epochs state; impl pool's historical endpoints Sep 11, 2025

golddydev changed the base branch from main to golddydev/stake-addresses-in-spo-state September 11, 2025 15:37

golddydev added 5 commits September 11, 2025 17:56

refactor: store vote record for spos in spo_state, subscribe to gover…

470eb33

…nance message - Renamed and reorganized subscription topics for clarity and consistency. - Introduced governance subscription handling in the SPOState module.

feat: implement pool updates and votes endpoints

b259433

- Added support for retrieving pool updates and votes in the SPOState module. - Updated PoolUpdates and PoolVotes structures to include relevant data. - Enhance serde for PoolUpdateEvent and VoteRecord

Merge branch 'golddydev/stake-addresses-in-spo-state' into golddydev/…

ef9e29b

…expand-epochs-state

fix: build issue

4921605

refactor: rename epoch activity couter to epochs state

a527d14

Base automatically changed from golddydev/stake-addresses-in-spo-state to main September 15, 2025 12:34

golddydev added 4 commits September 15, 2025 18:11

feat: implement pool spo endpoint

bc2d3e8

- Added new queries for retrieving pool live stake information and optimal pool sizing. - Implemented methods to get accounts' UTXO values and their sums. - Refactored existing code to improve clarity and maintainability.

revert: sancho net's config

9e0b106

Merge branch 'main' into golddydev/expand-epochs-state

9b5c8bf

fix: cargo fmt

6724c50

golddydev requested review from whankinsiv and sandtreader September 15, 2025 16:44

golddydev marked this pull request as ready for review September 15, 2025 16:44

golddydev linked an issue Sep 15, 2025 that may be closed by this pull request

Implement /pools/{pool_id}/blocks, updates, votes and /pools/{pool_id} endpoints #165

Closed

refactor: run several queries parellel for pool spo endpoint

b68e0e2

golddydev linked an issue Sep 15, 2025 that may be closed by this pull request

Rename epoch_activity_counter to epochs_state #174

Closed

whankinsiv requested changes Sep 15, 2025

View reviewed changes

golddydev marked this pull request as draft September 16, 2025 13:00

golddydev closed this Sep 16, 2025

golddydev deleted the golddydev/expand-epochs-state branch September 17, 2025 12:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: expand epochs state; impl pool's historical endpoints #173

feat: expand epochs state; impl pool's historical endpoints #173

Uh oh!

golddydev commented Sep 11, 2025 •

edited

Loading

Uh oh!

whankinsiv left a comment

Uh oh!

whankinsiv Sep 15, 2025

Uh oh!

whankinsiv Sep 15, 2025

Uh oh!

whankinsiv Sep 15, 2025

Uh oh!

whankinsiv Sep 15, 2025

Uh oh!

whankinsiv Sep 15, 2025

Uh oh!

whankinsiv Sep 15, 2025

Uh oh!

whankinsiv Sep 15, 2025

Uh oh!

whankinsiv Sep 15, 2025

Uh oh!

whankinsiv Sep 15, 2025

Uh oh!

golddydev Sep 16, 2025

Uh oh!

golddydev commented Sep 16, 2025

Uh oh!

Uh oh!

feat: expand epochs state; impl pool's historical endpoints #173

feat: expand epochs state; impl pool's historical endpoints #173

Uh oh!

Conversation

golddydev commented Sep 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Module Refactoring: Epoch Activity Counter → Epochs State

Key Changes

Implemented BF Endpoints

Fixes on several calculation

🆕 New Functionality & Data Structures

Refactor SPO State

New Common Types

Uh oh!

whankinsiv left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

golddydev commented Sep 16, 2025

Uh oh!

Uh oh!

golddydev commented Sep 11, 2025 •

edited

Loading