feat: Node syncing operation optimisation for the initial bootstrap with bulk sync atala operations #879
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mineme0110 <[email protected]> nodeoptimisation Signed-off-by: mineme0110 <[email protected]> nodeoptimisation Signed-off-by: mineme0110 <[email protected]> nodeoptimisation Signed-off-by: mineme0110 <[email protected]> nodeoptimisation Signed-off-by: mineme0110 <[email protected]> nodeoptimisation Signed-off-by: mineme0110 <[email protected]>
🦙 MegaLinter status:
|
| Descriptor | Linter | Files | Fixed | Errors |
|---|---|---|---|---|
| ✅ REPOSITORY | dustilock | yes | no | |
| ✅ REPOSITORY | git_diff | yes | no | |
| kics | yes | 1 | ||
| ✅ REPOSITORY | syft | yes | no |
See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff
MegaLinter is graciously provided by
Unit Test Results288 tests ±0 288 ✔️ ±0 19s ⏱️ -5s Results for commit 3ab886a. ± Comparison against base commit 5eb399e. This pull request removes 1 and adds 1 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
…efficiently and quicker Signed-off-by: mineme0110 <[email protected]>
mineme0110
changed the title
mineme0110
changed the title
yshyn-iohk
reviewed
May 5, 2025
...main/scala/io/iohk/atala/prism/node/cardano/dbsync/repositories/CardanoBlockRepository.scala
Show resolved
Hide resolved
yshyn-iohk
reviewed
May 5, 2025
src/main/scala/io/iohk/atala/prism/node/repositories/daos/AtalaObjectsDAO.scala
Outdated
Show resolved
Hide resolved
yshyn-iohk
reviewed
May 5, 2025
src/main/scala/io/iohk/atala/prism/node/repositories/daos/AtalaObjectsDAO.scala
Outdated
Show resolved
Hide resolved
yshyn-iohk
reviewed
May 5, 2025
There was a problem hiding this comment.
@mineme0110, could you take a look at my coments.
I'm concerned that we don't use the SQL cursor correctly.
It should be possible to fetch the blocks using stream and process this stream to the end.
…code to servuce layer the dao layer Signed-off-by: mineme0110 <[email protected]>
…ode from scratch Signed-off-by: mineme0110 <[email protected]>
…ode from scratch Signed-off-by: mineme0110 <[email protected]>
yshyn-iohk
approved these changes
May 6, 2025
atala-dev
added a commit
that referenced
this pull request
May 6, 2025
# [2.6.0](v2.5.0...v2.6.0) (2025-05-06) ### Bug Fixes * add validations to TimestampInfo ([#871](#871)) ([e7850e6](e7850e6)) * remove CORS ([#869](#869)) ([a2f55b5](a2f55b5)) ### Features * Node syncing operation optimisation for the initial bootstrap with bulk sync atala operations ([#879](#879)) ([21f52e7](21f52e7)) * postgres metrics ([#868](#868)) ([8a70e64](8a70e64))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR introduces bulk synchronization of the node state from the Cardano db-sync.
Bulk sync is a one-time, high-efficiency catch-up process that processes all Atala objects from the starting block(as defined in config
blockNumberSyncStart) in large batches of5000and stops atlastConfirmedBlockNo -blockConfirmationsToWait, after which it updates the sync pointer so that regular incremental syncing can resume.Screenshots
Checklists
Pre-submit checklist:
Pre-merge checklist: