-
Notifications
You must be signed in to change notification settings - Fork 63
feat(web-extension)!: emit wallet and id from activeWallet$ #1456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @mchappell 👏 🚀
|
4d61d22
4fa66e7 to
f8bb313
Compare
Using Lace, activeWallet and activeWalletId observables emit independently. In order to synchronise you need to know which emits first. Emitting both from the same observable eliminates potential race conditions
f8bb313 to
332eb02
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏 🚀
Using Lace, activeWallet and activeWalletId observables emit independently. In order to synchronise you need to know which emits first.
Emitting both from the same observable eliminates potential race conditions
LW-11406