-
Notifications
You must be signed in to change notification settings - Fork 63
feat(cardano-services): implement provider selection based on env variables and config #1463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
7fde95f to
55b50dd
Compare
|
packages/cardano-services/src/Program/programs/providerServer.ts
Outdated
Show resolved
Hide resolved
packages/cardano-services/src/Program/programs/providerServer.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
76494bc to
0d44798
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! 🚀
…iables and config
0d44798 to
6c8c97d
Compare
For most providers, we have multiple implementations.
This feature allows us to pick which implementation we run inside the related HttpService.
Context
This PR is based on
blockfrostbranch and can be merged directly into themasteronce theblockfrostbranch is merged.Proposed Solution
It's backward compatible by respecting or throwing errors in case of conflict with the old env vars or configs.
For example,
USE_SUBMIT_APIis set to any value, setting theTX_SUBMIT_PROVIDERvalue will throw an error.Important Changes Introduced