-
Notifications
You must be signed in to change notification settings - Fork 63
fix: correctly set handle owner when handle is upgraded to cip68 #1468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
add new chain-sync dataset with a problematic block
bf4d3aa
to
71204e0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Context
Found some suspicious logs in mainnet handle provider:
It is a valid handle that was minted just once by upgrading a cip25 handle into cip68.
The bug is caused by withHandles mapper overwriting handles found in outputs with the ones found in mint (burned), therefore setting address to
null
.Proposed Solution
projection-typeorm
Important Changes Introduced