-
Notifications
You must be signed in to change notification settings - Fork 61
test(e2e): fix cip25 v2 test #1537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
it was setting version as part of the map under <asset_name> but the spec specifies that it has to be under the '721' map
757ffc2 to
f3561ff
Compare
|
mirceahasegan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
This can be merged now right @mkazlauskas? |
Context
it was setting version as part of the map under <asset_name> but the spec specifies that it has to be under the '721' map
Proposed Solution
Important Changes Introduced