Fix/output mapping on hw #1618
Merged
Fix/output mapping on hw #1618
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iccicci
previously approved these changes
Apr 16, 2025
Collaborator
iccicci
left a comment
iccicci
left a comment
There was a problem hiding this comment.
Apart from a couple of side comments (probably outside of the scope of this PR),
LGTM!
iccicci
approved these changes
Apr 17, 2025
AngelCastilloB
force-pushed
the
fix/output-mapping-on-hw
branch
from
3687665 to
ed91155
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The change introduced in #1616 was not completely accurate. It assumes all otuputs on the transaction will be encoded in the same format, but this is not necesarily the case, Legacy format is more compact, dApps can take this to their advantage and use legacy encoding for outputs that do not need babbage fields, reducing transaction size. So we should assume outputs could (and probably will) be encoded using different formats.
Proposed Solution
check raw CBOR of all outputs and determined their format.