Skip to content

refactor: relax CIP-8 signing threshold from 100 to 190 #1643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 5, 2025
Merged

refactor: relax CIP-8 signing threshold from 100 to 190 #1643

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
67acfa5
refactor: relax CIP-8 signing threshold from 100 to 190
rhyslbw Aug 5, 2025
be56211
chore: upgrade Ubuntu base image from 20.04 to 22.04
rhyslbw Aug 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
ARG UBUNTU_VERSION=20.04
ARG UBUNTU_VERSION=22.04

FROM ubuntu:${UBUNTU_VERSION} AS ubuntu-nodejs
ARG NODEJS_MAJOR_VERSION=18
Expand Down
2 changes: 1 addition & 1 deletion packages/hardware-ledger/src/LedgerKeyAgent.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ const LedgerConnection = (_LedgerConnection as any).default
: _LedgerConnection;
type LedgerConnection = _LedgerConnection;

const CIP08_SIGN_HASH_THRESHOLD = 100;
const CIP08_SIGN_HASH_THRESHOLD = 190;

const isUsbDevice = (device: any): device is USBDevice =>
typeof USBDevice !== 'undefined' && device instanceof USBDevice;
Expand Down
Loading