fix(hardware-trezor): support derivationType in getXpub method #1651
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkazlauskas
requested changes
Sep 5, 2025
mkazlauskas
approved these changes
Sep 5, 2025
- add `derivationType?: MasterKeyGeneration` to `GetTrezorXpubProps` - update `getXpub` and `createWithDevice` to accept and pass `derivationType` - include `derivationType` in `cardanoGetPublicKey` call - add mapping from `MasterKeyGeneration` to Trezor `CardanoDerivationType` - improve seed length handling for ICARUS vs ICARUS_TREZOR - import `MasterKeyGeneration` type from `@cardano-sdk/key-management` - test all derivation types (ICARUS, ICARUS_TREZOR, LEDGER) - verify parameter passing from `trezorConfig` to `getXpub` - cover error handling (TransportError, AuthenticationError) - add integration tests for `createWithDevice` - mock Trezor connection to avoid device dependencies - improve test organization with shared utilities and hoisted setup - enhance coverage for master key generation schemes
rhyslbw
force-pushed
the
fix/trezor-getxpub-derivation-type
branch
from
918568c to
a9dc79f
Compare
AngelCastilloB
approved these changes
Sep 5, 2025
|
We have a couple of pre-existing test failures in the Trezor suite, but I won't fix them here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found some issues during integration. Fixes, improved test coverage, improved docs contained within