Skip to content

Conversation

@Mr-Leshiy
Copy link
Contributor

@Mr-Leshiy Mr-Leshiy commented Dec 5, 2025

Description

Needed for input-output-hk/catalyst-voices#3817.

Related Issue(s)

Part of input-output-hk/catalyst-voices#3788

Description of Changes

  • Added new DocumentRef type.
  • Modified all document generators functions, with adding optional arguments id and ver, replace SignedDocumentBase arg types with new DocumentRef.

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@Mr-Leshiy Mr-Leshiy added the draft Draft label Dec 5, 2025
@Mr-Leshiy Mr-Leshiy added the squad: gatekeepers Catalyst App Backend, System Development & Integration Team label Dec 5, 2025
@Mr-Leshiy Mr-Leshiy moved this from New to 👀 In review in Catalyst Dec 5, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2025

📚 Docs Preview

The docs for this PR can be previewed at the following URL:

https://docs.dev.projectcatalyst.io/libs/feat/signed-doc-create_metadata

@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2025

Test Report | ${\color{lightgreen}Pass: 601/601}$ | ${\color{red}Fail: 0/601}$ |

@Mr-Leshiy Mr-Leshiy added review me PR is ready for review and removed draft Draft labels Dec 5, 2025
Copy link
Collaborator

@apskhem apskhem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mr-Leshiy Mr-Leshiy merged commit f3dea0f into main Dec 5, 2025
23 checks passed
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Catalyst Dec 5, 2025
@Mr-Leshiy Mr-Leshiy deleted the feat/signed-doc-create_metadata branch December 5, 2025 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review me PR is ready for review squad: gatekeepers Catalyst App Backend, System Development & Integration Team

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

3 participants